Merge pull request #2631 from beetbox/Fix-2622

Do not warn about a BrokenPipeError we do consider - Fix #2622
beetbox · Jul 22, 2017 · 6160fa8 · 6160fa8
2 parents c06eca7 + 8da5c0f
commit 6160fa8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/beets/ui/__init__.py b/beets/ui/__init__.py
@@ -1276,7 +1276,7 @@ def main(args=None):
     except IOError as exc:
         if exc.errno == errno.EPIPE:
             # "Broken pipe". End silently.
-            pass
+            sys.stderr.close()
         else:
             raise
     except KeyboardInterrupt:

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -12,6 +12,11 @@ New features:
 
 Fixes:
 
+* Prevent Python from warning about a ``BrokenPipeError`` being ignored even
+  though we do take it into account. This was an issue when using beets in
+  simple shell scripts.
+  Thanks to :user:`Azphreal`.
+  :bug:`2622` :bug:`2631`
 * :doc:`/plugins/replaygain`: Fix a regression in the previous release related
   to the new R128 tags. :bug:`2615` :bug:`2623`
 * :doc:`/plugins/lyrics`: The MusixMatch backend now detect and warns