Merge pull request #3060 from TaizoSimpson/issue-3501

When selecting items to modify, use configured order
beetbox · Oct 25, 2018 · 9556ab3 · 9556ab3
2 parents 0a74e0f + b901eb3
commit 9556ab3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/beets/ui/commands.py b/beets/ui/commands.py
@@ -1376,10 +1376,10 @@ def modify_items(lib, mods, dels, query, write, move, album, confirm):
     # objects.
     print_(u'Modifying {0} {1}s.'
            .format(len(objs), u'album' if album else u'item'))
-    changed = set()
+    changed = []
     for obj in objs:
-        if print_and_modify(obj, mods, dels):
-            changed.add(obj)
+        if print_and_modify(obj, mods, dels) and obj not in changed:
+            changed.append(obj)
 
     # Still something to do?
     if not changed:

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -98,6 +98,10 @@ Fixes:
 * Missing album art file during an update no longer causes a fatal exception
   (instead, an error is logged and the missing file path is removed from the
   library). :bug:`3030`
+* Fixed the ordering of items when manually selecting changes while updating
+  tags
+  Thanks to :user:`TaizoSimpson`.
+  :bug:`3501`
 
 .. _python-itunes: https://github.com/ocelma/python-itunes