Documentation for #1555/#1556

beetbox · Aug 1, 2015 · 96c5121 · 96c5121
1 parent 4818264
commit 96c5121
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/beetsplug/fetchart.py b/beetsplug/fetchart.py
@@ -437,6 +437,8 @@ def _fetch_image(self, url):
                                 util.displayable_path(fh.name))
                 return fh.name
         except (IOError, requests.RequestException, TypeError):
+            # Handling TypeError works around a urllib3 bug:
+            # https://github.com/shazow/urllib3/issues/556
             self._log.debug(u'error fetching art')
 
     def _is_valid_image_candidate(self, candidate):

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -83,6 +83,8 @@ Fixes:
   plugin-provided ones. This distinction was becoming increasingly unreliable.
 * :doc:`/plugins/duplicates`: Fix a Unicode warning when paths contained
   non-ASCII characters. :bug:`1551`
+* :doc:`/plugins/fetchart`: Work around a urllib3 bug that could cause a
+  crash. :bug:`1555` :bug:`1556`
 
 .. _Python bug: http://bugs.python.org/issue16512