-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importer duplicate detection: configurable field set #1133
Comments
Thanks for filing this. To summarize the other discussion, you wanted to add |
I have a similar issue where a single has the same title as an album for the same artist, in most cases the year will be the same too so it's great to see that you've widened the solution to configure fields without limitation, allows me to use albumtype, which will be ideal for this scenario. |
Any chance to see this implemented? BTW, when importing in --singletons mode it seems that the duplicate detection code uses ony author and title, and this bug gets quite annoying. e.g. for jazz music it's common to have many version of the same song by the same artist. |
I don't mean this to sound dismissive, but you can make the chances much higher by doing some work on it yourself! The current status is that we think this is a good idea and important; it's just a matter of finding someone with the time to implement it. |
I was looking into adding this but it turns out it might run a lot deeper than I initially thought. The importer uses The main issue seems to be with modifying how Both Now we could just fetch We can't even easily use I may have completely missed something simple here, but from my preliminary look it doesn't seem like this will be an easy thing to add 😢. What do you think @sampsyo? |
Hi, @jackwilsdon! It's great to hear from you. You're right; this is a bit complicated. Here's the fundamental problem, I think: But when we have an as-is import, where the information comes from the current metadata on the files, things are more complicated. How do we get the "current artist" for a collection of tracks? We can only guess it by taking the majority. That's why there's the coupling with I think the right approach is probably to make |
Hey @sampsyo, sorry for pretty much disappearing off the face of the earth recently! 😆 Does fields = ['artist', 'album', 'albumartist', 'year', 'disctotal', 'mb_albumid', 'label', 'catalognum', 'country', 'media', 'albumdisambig'] Regarding your last point; would |
Well I'll be damned; I totally forgot that Currently, self.cur_artist = artist
self.cur_album = album we'll instead have: self.cur_metadata = cur_metadata to save that for later. Finally, Does that make any sense? |
Currently, beets uses only album and artist. I'd like to use year too. Maybe make it configurable?
(this discussion started in #1131)
The text was updated successfully, but these errors were encountered: