-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the version error in the release workflow #5274
Conversation
Hey @snejus if you wanna push your markdown code to this branch, we can get it all working and fixed in one PR. |
Cool, will do! To be clear, do you mean the code that converts |
Yes, the part I removed. I removed a bunch of stuff but if you actually have it working, then we might as well add it back in. It'll be a bit of a pain to make it so it's output as part of the action (which is why I removed it in the first place) but it should be manageable. |
090b38c
to
cb6d569
Compare
@Serene-Arc thanks for the confirmation - this makes sense. I don't think this should pose too many issues - let me get on it. |
a5d126e
to
cb6d569
Compare
@Serene-Arc See the commits I have just pushed |
See the resulting changelog for With this release, beets now requires Python 3.7 or later (it removes support for Python 3.6). Major new features
New features
Bug fixes
For plugin developers
For packagers
Other changes
|
eddd02f
to
d9c3b6f
Compare
Black requires that there be double quotes instead of single
Looking at the logs, it's using the ref before the one that increments the version in the previous action in the workflow. This code is from actions/checkout#439 (comment) and supposedly fixes this by making it pull specifically from master, rather than the ref that the workflow was called on.
d9c3b6f
to
65587c2
Compare
I rebased the PR off the most recent |
Additionally, update the 'in progress' header in the changelog: instead of using a specific version number, simply say 'Unreleased' since we do not know in advance what version will the changes be eventually released. This also simplifies latest changelog retrieval.
65587c2
to
d2a94c1
Compare
Cool, thanks. I've reviewed the changes and it seems good to me. I'll merge and we can make another release whenever. |
This hopefully fixes the issue we experienced where the version was not incremented before the package was built. This should make sure that it works correctly.