Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --pretend option to splupdate command #4573

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

JOJ0
Copy link
Member

@JOJ0 JOJ0 commented Dec 6, 2022

Description

When working with smart playlists, often it's desired to see if a specific query is working as expected. This implements a dry-run for smart playlists existing in the beets configuration. A new config option is available that let's the user choose whether the dry-run should display what's actually written to the m3u file (the file paths) or a regular "items output" shoud be displayed.

To Do

  • Documentation.
  • Changelog.

@JOJ0 JOJ0 marked this pull request as ready for review December 6, 2022 06:50
@JOJ0
Copy link
Member Author

JOJ0 commented Dec 6, 2022

Finished and ready for a final review.

Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; this looks quite straightforward! No comments from me; please merge when ready. 🎉

@JOJ0 JOJ0 merged commit aabd163 into beetbox:master Feb 1, 2023
@JOJ0
Copy link
Member Author

JOJ0 commented Feb 1, 2023

Oh! Great. Thanks a lot for the review! Merged.

JOJ0 added a commit to JOJ0/beets that referenced this pull request Mar 8, 2023
JOJ0 added a commit to JOJ0/beets that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants