-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing ISRC to tracks in Spotify plugin #4992
Comments
@arsaboo help me out: Where would you see this additional fetch in the code? I'm unsure if I want to get my hands dirty on that plugin yet :-) Maybe you are quicker ;-) |
FYI MusicBrainz often contains this info as well and beets fetches is as well and writes it to tracks. Also the Deezer plugin fetches it, it's easier with the Deezer API I guess, since it is included with the album's response we get already: https://github.com/beetbox/beets/blob/708a04d4a88eb955f261a21f0b1146c9e2ae0a55/beetsplug/deezer.py#L165C21-L165C21 Update: Hey but wait, deezer plug does an additional fetch for the tracks already: https://github.com/beetbox/beets/blob/708a04d4a88eb955f261a21f0b1146c9e2ae0a55/beetsplug/deezer.py#L111C17-L111C17 Spotify plug doesn't do that extra-fetch for tracks details! |
Support ISRC track field in Spotify plugin.
The difficulty is that we currently if I'm not mistaken, only get a "Simplified Track Object" track object from Spotify while fetching album info: https://developer.spotify.com/documentation/web-api/reference/get-an-album -> look for this in the docs:
I wanted to instantly open a PR to just add external_ids.isrc to the plugin but it's just not there in the response we currently get from the albums endpoint. We would need an additional request to this endpoint to get it: https://developer.spotify.com/documentation/web-api/reference/get-track
Because we need this data:
There might be a better way, maybe asking the albums endpoint to include that field. Not sure if that's possible.
The text was updated successfully, but these errors were encountered: