Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acousticbrainz and absubmit plugins should be deprecated #4627

Closed
mtrolley opened this issue Jan 8, 2023 · 4 comments · Fixed by #4636
Closed

acousticbrainz and absubmit plugins should be deprecated #4627

mtrolley opened this issue Jan 8, 2023 · 4 comments · Fixed by #4636
Labels
bug bugs that are confirmed and actionable

Comments

@mtrolley
Copy link
Contributor

mtrolley commented Jan 8, 2023 •
edited
Loading

Acousticbrainz has shut down and will go completely offline in early 2023 according to that blog post. The acousticbrainz and absubmit plugins should be deprecated.

Attempting to use it now just results in a lot of "acousticbrainz did not provide info about..." messages.
@mtrolley mtrolley changed the title acousticbrainz plugin should be deprecated acousticbrainz and absubmit plugins should be deprecated Jan 8, 2023
@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Jan 9, 2023
@sampsyo
Copy link
Member

sampsyo commented Jan 9, 2023

Thanks! Printing out a more useful error message would be good.

@mtrolley
Copy link
Contributor Author

mtrolley commented Jan 9, 2023

I'm working on a change to deprecate both plugins. I need to test still, but should hopefully have a PR up soon.

@sampsyo
Copy link
Member

sampsyo commented Jan 9, 2023

Wow; wonderful news!!

@mtrolley mtrolley mentioned this issue Jan 16, 2023
Merged
3 tasks
@mtrolley
Copy link
Contributor Author

@sampsyo - How do I get this PR reviewed?

@snejus snejus mentioned this issue Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate absubmit and acousticbrainz plugins
2 participants
@sampsyo @mtrolley