Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confuse dependency requirement permits invalid versions #4167

Closed
billyjanitsch opened this issue Nov 27, 2021 · 2 comments
Closed

confuse dependency requirement permits invalid versions #4167

billyjanitsch opened this issue Nov 27, 2021 · 2 comments
Labels
bug bugs that are confirmed and actionable

Comments

@billyjanitsch
Copy link
Contributor

Problem

Beets declares a dependency on confuse>=1.0.0:

beets/setup.py

Line 92 in e3f4e19

'confuse>=1.0.0',

But it uses confuse.Optional, which was only added in confuse@1.5.0:

confuse.Optional(str)

This causes beets to crash if you happen to have an earlier version of confuse installed, e.g., 1.4.0:

AttributeError: module 'confuse' has no attribute 'Optional'

I assume the fix is to increase the dependency requirement to confuse>=1.5.0.

Setup

  • OS: macOS 12.0.1
  • Python version: 3.9.9
  • beets version: 1.6.0
  • Turning off plugins made problem go away (yes/no):

My configuration (output of beet config) is:

n/a
@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Nov 28, 2021
@sampsyo
Copy link
Member

sampsyo commented Nov 28, 2021

Thanks! I had not noticed we had started using more recent Confuse features. I'll change the dependency now. ✨

@basings
Copy link

basings commented Jan 28, 2023

I just ran into this problem as well, I looked into https://github.com/beetbox/beets/blob/master/setup.py yet the requirements is properly specified.

beets v 1.6.9.
python 3.11.1

I solved it by installing the right confuse version pip install --force-reinstall -v "confuse==1.5.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

3 participants