Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embyupdate: Allow direct configuration of user ID for private users #4402

Closed
JoshDi opened this issue Jul 6, 2022 · 2 comments · Fixed by #4883
Closed

embyupdate: Allow direct configuration of user ID for private users #4402

JoshDi opened this issue Jul 6, 2022 · 2 comments · Fixed by #4883
Labels
feature features we would like to implement

Comments

@JoshDi
Copy link

JoshDi commented Jul 6, 2022 •
edited
Loading

In the embyupdate.py plugin, if the admin user listed in the beets config is hidden from login screens, the embyupdate plugin will fail and not find the username.

I am using an API key, which is server wide so the username does not really matter. Therefore the get_user function should just return the user provided in the beets config

We should also allow for the emby user ID (string/hash) to be supplied directly from the beets config to avoid this situation.

can this change be made please?
@sampsyo sampsyo changed the title embyupdate.py does not work if admin user is private embyupdate: Allow direct configuration of user ID for private users Jul 7, 2022
@sampsyo
Copy link
Member

sampsyo commented Jul 7, 2022

Sounds very reasonable! Any chance you could try putting together a PR to show how this would work?

@sampsyo sampsyo added the feature features we would like to implement label Jul 7, 2022
@shoriminimoe
Copy link
Contributor

I happened to encounter this recently. I'm happy to submit a PR for this.

shoriminimoe added a commit to shoriminimoe/beets that referenced this issue Aug 26, 2023
@shoriminimoe
feat[embyupdate]: add handling for private users
b7e3d37 
Adds a `userid` config option for the `embyupdate` plugin. When the
`userid` is provided, the Emby user lookup is bypassed. This avoids a
failure to get the user ID for private users.

Closes: beetbox#4402
@shoriminimoe shoriminimoe mentioned this issue Aug 26, 2023
Merged
3 tasks
Louson pushed a commit to Louson/beets that referenced this issue Sep 26, 2023
@shoriminimoe
feat[embyupdate]: add handling for private users
2a25173 
Adds a `userid` config option for the `embyupdate` plugin. When the
`userid` is provided, the Emby user lookup is bypassed. This avoids a
failure to get the user ID for private users.

Closes: beetbox#4402
@snejus snejus mentioned this issue Jun 4, 2024
Merged
@snejus snejus mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature features we would like to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add embyupdate userid config option shoriminimoe/beets
3 participants
@sampsyo @JoshDi @shoriminimoe