Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing video tracks identified by MusicBrainz during import and in missing plugin #1210

Closed
fortes opened this issue Jan 7, 2015 · 4 comments
Labels
feature features we would like to implement

Comments

@fortes
Copy link
Member

fortes commented Jan 7, 2015

Musicbrainz albums sometimes have video tracks in them (example: http://musicbrainz.org/release/49da37ee-065a-4d7f-a204-9dda8047aad4 ) -- is it possible to ignore video tracks we importing or using beet missing?

@sampsyo sampsyo changed the title Ignore missing video tracks from Musicbrainz missing: Ignore missing video tracks identified by MusicBrainz Jan 7, 2015
@sampsyo sampsyo added the feature features we would like to implement label Jan 7, 2015
@sampsyo
Copy link
Member

sampsyo commented Jan 7, 2015

Not currently, but (if there's a reliable way of identifying them) then this seems like a worthy goal.

@fortes
Copy link
Member Author

fortes commented Jan 7, 2015

Here's the XML: http://musicbrainz.org/ws/2/release/49da37ee-065a-4d7f-a204-9dda8047aad4?inc=artists+artist-credits+recordings+aliases

Looks like the track has <video>true</video> in the response.

@sampsyo
Copy link
Member

sampsyo commented Jan 7, 2015

Cool. If anyone's interested in taking this on, the first step will be propagating that information from MB to the beets database.

@Freso
Copy link
Member

Freso commented Jan 9, 2015

Related Picard issue: metabrainz/picard#383 - note that this is not just videos, there are plenty of "enhanced" cds with e.g. bonus MP3s on the data section.

@sampsyo sampsyo changed the title missing: Ignore missing video tracks identified by MusicBrainz Ignore missing video tracks identified by MusicBrainz during import and in missing plugin Sep 13, 2017
nguillaumin added a commit to nguillaumin/beets that referenced this issue Dec 31, 2017
This ignores non-audio tracks during import:
- Data tracks, based on their title `[data track]` (which seems to be
the MusicBrainz convention, as there's no specific flag to indicate
that a track is a data one),
- Video tracks, based on the `video=true` attribute.

It's similar to the Picard changes mentioned in beetbox#1210, except it doesn't
deal with `[silence]` tracks: These ones will probably require a setting
to let the user control if they should be imported or not.
@sampsyo sampsyo closed this as completed in 71b4d5c Jan 1, 2018
sampsyo added a commit that referenced this issue Jan 1, 2018
Fixes #1210: Skip non-audio tracks from MusicBrainz
nguillaumin added a commit to nguillaumin/beets that referenced this issue Jan 2, 2018
This is related to beetbox#2688 where a list of hard-coded non-audio formats to
ignore has been added. Some users may want to rip the audio portion of
video tracks (e.g. DVD-Video) so it would be beneficial to let them
control exactly which formats to ignore.

I added a `ignored_formats` setting for that purpose and moved the
hard-coded list into the config. Test and documentation have been
updated accordingly.

Aside: I also clarified the changelog a bit regarding this change and
the related one for beetbox#1210.
msjyoo pushed a commit to msjyoo/beets that referenced this issue Jan 4, 2018
This is related to beetbox#2688 where a list of hard-coded non-audio formats to
ignore has been added. Some users may want to rip the audio portion of
video tracks (e.g. DVD-Video) so it would be beneficial to let them
control exactly which formats to ignore.

I added a `ignored_formats` setting for that purpose and moved the
hard-coded list into the config. Test and documentation have been
updated accordingly.

Aside: I also clarified the changelog a bit regarding this change and
the related one for beetbox#1210.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

3 participants