-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on import with UTF-8 names under Mac OS X #1248
Comments
Disabling keyfinder plugin stops crashing. Keyfinder configuration: |
Hi! Thank you for reporting. I believe this should be fixed in git due to some recent refactoring of the logging machinery. If you get a chance, can you confirm that this is working now? |
Unfortunately using git master just changes the error: Traceback (most recent call last): |
Wow, a completely different bug! Thanks for reporting. Looking into this now. |
We were being sloppy about bytes output from the process. Also, it seems like the tools outputs the path also, so it's necessary to break on whitespace to actually get the key name.
I took a closer look and found several glaring issues in the keyfinder plugin. 😱 They should be fixed now. |
Good, updating to master of masters and testing, stay tuned 😛 |
I have a new bug, but at least, now, it doesn't stop importing:
|
The beets loggers now, as proposed in #1044, do their utmost to avoid crashing when logged values are not valid Unicode or Unicode-convertible. This came up urgently when a `CalledProcessError` could not be logged with `'u{}'.format()` (!!!) so we needed to some manner of conversion, but it should be possible to log paths without `displayable_path`. In fact, it may be time to retire `displayable_path` for the most part.
Thank you again, and my apologies for the number of bugs you're uncovering in this (apparently neglected) plugin. This latest one should also be fixed now. |
No need to apologize, it's been my pleasure to help a fellow developer uncover and kill nasty bugs on a software I do like 👍 |
Traceback (most recent call last): beets crashes on import when getting to Insomnia: The Erick Sermon Compilation Album The Wixtons beet lyrics Insomnia: The Erick Sermon Compilation Album The Wixtons Jah Boogie: Not sure if this is related to this bug, as I didn't want to create a duplicate bug report. |
@darthanubis This is a separate bug. Can you provide a copy of your database for testing (associated with a new issue)? |
Trying to import any file with unicode names, or inside a unicode-named folder, crashes in Mac OS X.
Tested with beets 1.3.8 and 1.3.10, under Mac OS X 10.9.5 and 10.10.0.
Traceback (most recent call last):
File "/usr/local/bin/beet", line 9, in
load_entry_point('beets==1.3.10', 'console_scripts', 'beet')()
File "/Library/Python/2.7/site-packages/beets/ui/init.py", line 945, in main
_raw_main(args)
File "/Library/Python/2.7/site-packages/beets/ui/init.py", line 935, in _raw_main
subcommand.func(lib, suboptions, subargs)
File "/Library/Python/2.7/site-packages/beets/ui/commands.py", line 873, in import_func
import_files(lib, paths, query)
File "/Library/Python/2.7/site-packages/beets/ui/commands.py", line 845, in import_files
session.run()
File "/Library/Python/2.7/site-packages/beets/importer.py", line 305, in run
pl.run_parallel(QUEUE_SIZE)
File "/Library/Python/2.7/site-packages/beets/util/pipeline.py", line 299, in run
out = self.coro.send(msg)
File "/Library/Python/2.7/site-packages/beets/util/pipeline.py", line 181, in coro
func(*(args + (task,)))
File "/Library/Python/2.7/site-packages/beets/importer.py", line 1268, in plugin_stage
func(session, task)
File "/Library/Python/2.7/site-packages/beetsplug/keyfinder.py", line 52, in imported
self.find_key(task.items)
File "/Library/Python/2.7/site-packages/beetsplug/keyfinder.py", line 70, in find_key
.format(key, util.displayable_path(item.path)))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 104: ordinal not in range(128)
The text was updated successfully, but these errors were encountered: