Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: embed setting not respected on import (in auto mode) #1671

Open
simonbcn opened this issue Oct 29, 2015 · 8 comments
Open

convert: embed setting not respected on import (in auto mode) #1671

simonbcn opened this issue Oct 29, 2015 · 8 comments
Labels
bug bugs that are confirmed and actionable

Comments

@simonbcn
Copy link

beets git version

....
plugins: convert replaygain lastgenre fetchart info 

fetchart:
  auto: yes
  maxwidth: 300
  cautious: yes
match:
  strong_rec_thresh: 0.30
  max_rec:
    missing_tracks: strong

import:
  art: yes
  languages: es en

paths:
  default: $albumartist/$album/$track - $title
  singleton: $artist - $title
  comp: Varios/$album/$track - $title

lastgenre:
  canonical: yes

convert:
  auto: yes
  tmpdir: /tmp
  format: mp3
  max_bitrate: 250
  embed: yes
  quiet: yes
......

After beet import an album, it downloads the album art and transcode the files but it doesn't embed the art:

$ beet info -i 'art' Música/Avicii/Stories/01\ -\ Waiting\ for\ Love.mp3 
art: False
@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Oct 29, 2015
@sampsyo
Copy link
Member

sampsyo commented Oct 29, 2015

That's strange. As usual, can you please include a verbose log from beets when you observed the problem?

More on filing a good bug report: http://adriansampson.net/blog/bugrubric.html

@simonbcn
Copy link
Author

$ beet config              

paths:
    default: $albumartist/$album/$track - $title
    singleton: $artist - $title
    comp: Varios/$album/$track - $title
convert:
    auto: yes
    tmpdir: /tmp
    command: ffmpeg -i $source -y -codec:a libmp3lame -vn -qscale:a 1 $dest
    extension: mp3
    embed: yes
    quiet: yes
    threads: 7
    never_convert_lossy_files: yes
    format: mp3
    dest:
    copy_album_art: no
    max_bitrate: 500

    paths: {}
    pretend: no
    formats:
        alac:
            command: ffmpeg -i $source -y -vn -acodec alac $dest
            extension: m4a
        aac:
            command: ffmpeg -i $source -y -vn -acodec libfaac -aq 100 $dest
            extension: m4a
        opus: ffmpeg -i $source -y -vn -acodec libopus -ab 96k $dest
        mp3: ffmpeg -i $source -y -vn -aq 2 $dest
        flac: ffmpeg -i $source -y -vn -acodec flac $dest
        ogg: ffmpeg -i $source -y -vn -acodec libvorbis -aq 2 $dest
        wma: ffmpeg -i $source -y -vn -acodec wmav2 -vn $dest
scrub:
    auto: yes
fetchart:
    auto: yes
    maxwidth: 300
    cautious: yes
    minwidth: 0
    sources:
    - coverart
    - itunes
    - amazon
    - albumart
    cover_names:
    - cover
    - front
    - art
    - album
    - folder
    remote_priority: no
    enforce_ratio: no
duplicates:
    path: yes
    count: no
    full: no
    format: ''
    keys: []
    move: ''
    tag: ''
    copy: ''
    tiebreak: {}
    album: no
    strict: no
    checksum: ''
    merge: no
    delete: no
embedart:
    auto: yes
    maxwidth: 300
    remove_art_file: yes
replaygain:
    backend: bs1770gain
    overwrite: yes
    targetlevel: 89
    auto: yes
    chunk_at: 5000
    method: replaygain
lastgenre:
    canonical: yes
    count: 1
    source: album
    force: yes
    min_weight: 10
    auto: yes
    whitelist: yes
    separator: ', '
    fallback:
library: /home/simon/.beets/musiclibrary.blb

plugins: convert replaygain lastgenre fetchart info discogs scrub duplicates badfiles replaygain
directory: "/home/simon/M\xFAsica/"

import:
    art: yes
    languages: es en

match:
    strong_rec_thresh: 0.3
    max_rec:
        missing_tracks: strong
discogs:
    tokenfile: discogs_token.json
    apikey: REDACTED
    apisecret: REDACTED
    source_weight: 0.5
$ beet -v import /dunehd/Musica\ pendiente/Avicii-Stories-CD-FLAC-2015-VOLDiES/
user configuration: /home/simon/.config/beets/config.yaml
data directory: /home/simon/.config/beets
plugin paths: 
Sending event: pluginload
library database: /home/simon/.beets/musiclibrary.blb
library directory: /home/simon/Música
Sending event: library_opened
Sending event: import_begin
Sending event: import_task_created
Sending event: import_task_start
Looking up: /dunehd/Musica pendiente/Avicii-Stories-CD-FLAC-2015-VOLDiES
Tagging Avicii - Stories
No album IDs found.
Search terms: Avicii - Stories
Album might be VA: False
discogs: Communication error while searching for 'Avicii Stories': Only unicode objects are escapable. Got XQoOecWCCgbpXpkCOLJgobbSXIpjJAQkKMsDjzHb of type <type 'str'>.
Evaluating 5 candidates.
Candidate: Avicii - Stories
Success. Distance: 0.00
Candidate: Avicii - Stories
Success. Distance: 0.00
Candidate: Avicii - Stories
Success. Distance: 0.00
Candidate: Avicii - Stories
Success. Distance: 0.03
Candidate: Avicii - Stories
Success. Distance: 0.05

/dunehd/Musica pendiente/Avicii-Stories-CD-FLAC-2015-VOLDiES (14 items)
Tagging:
    Avicii - Stories
URL:
    http://musicbrainz.org/release/9408288b-4d6c-4df5-9e08-ee65498a0535
(Similarity: 100.0%) (CD, 2015, XE, PRMD)
 * Waiting For Love       -> Waiting for Love
 * Talk To Myself         -> Talk to Myself
 * For A Better Day       -> For a Better Day
 * Can't Catch Me         -> Can’t Catch Me
 * Somewhere In Stockholm -> Somewhere in Stockholm
Sending event: import_task_choice
found duplicates: [547]
This album is already in the library!
Old: 14 items, MP3, 226kbps, 54:40, 0.0 B
New: 14 items, FLAC, 949kbps, 54:39, 372.4 MiB
[S]kip new, Keep both, Remove old? r
Sending event: import_task_apply
0 of 14 items replaced
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
artresizer: method is (2, (6, 7, 7))
artresizer: ImageMagick resizing /tmp/tmpvITp1A.jpg to /tmp/tmpacW5uK.jpg
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
replaygain: analyzing Avicii - Stories
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
removing 14 old duplicated items
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/01 - Waiting for Love.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/02 - Talk to Myself.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/03 - Touch Me.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/04 - Ten More Days.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/05 - For a Better Day.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/06 - Broken Arrows.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/07 - True Believer.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/08 - City Lights.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/09 - Pure Grinding.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/10 - Sunset Jesus.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/11 - Can’t Catch Me.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/12 - Somewhere in Stockholm.mp3
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/13 - Trouble.mp3
Sending event: database_change
Sending event: database_change
Sending event: item_removed
deleting duplicate /home/simon/Música/Avicii/Stories/14 - Gonna Love Ya.mp3
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
Sending event: after_write
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: import_task_files
Sending event: art_set
Sending event: database_change
Sending event: album_imported
Sending event: import
Sending event: cli_exit

@sampsyo
Copy link
Member

sampsyo commented Oct 30, 2015

Is it possible to reproduce this using an explicit beet convert command, or does it only happen during import (i.e., with convert's auto mode)?

Also, I am now pushing a commit that adds a debug line when convert embeds album art. This might provide a little more information (in -vv mode).

sampsyo added a commit that referenced this issue Oct 30, 2015
@simonbcn
Copy link
Author

simonbcn commented Nov 1, 2015

With beet convert it works:

$ beet -vv convert salvatore -d /tmp
user configuration: /home/simon/.config/beets/config.yaml
data directory: /home/simon/.config/beets
plugin paths: 
Sending event: pluginload
library database: /home/simon/.beets/musiclibrary.blb
library directory: /home/simon/Música
Sending event: library_opened
Lana Del Rey - Honeymoon - Salvatore
Convert? (Y/n) 
convert: Copying /home/simon/Música/Lana Del Rey/Honeymoon/10 - Salvatore.mp3
Sending event: write
zero: comments:  -> None
Sending event: after_write
convert: embedding album art from /home/simon/Música/Lana Del Rey/Honeymoon/cover.1.jpg
convert: embedding /home/simon/Música/Lana Del Rey/Honeymoon/cover.1.jpg
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: after_convert
Sending event: cli_exit

@simonbcn
Copy link
Author

simonbcn commented Nov 1, 2015

With beet import:

user configuration: /home/simon/.config/beets/config.yaml
data directory: /home/simon/.config/beets
plugin paths: 
Sending event: pluginload
library database: /home/simon/.beets/musiclibrary.blb
library directory: /home/simon/Música
Sending event: library_opened
Sending event: import_begin
Sending event: import_task_created
Sending event: import_task_start
Looking up: /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES
Tagging Lana Del Rey - Honeymoon
No album IDs found.
Search terms: Lana Del Rey - Honeymoon
Album might be VA: False
Evaluating 5 candidates.
Candidate: Lana Del Rey - Honeymoon
Success. Distance: 0.00
Candidate: Lana Del Rey - Honeymoon
Success. Distance: 0.00
Candidate: Lana Del Rey - Honeymoon
Success. Distance: 0.00
Candidate: Lana Del Rey - Honeymoon
Success. Distance: 0.00
Candidate: Lana Del Rey - Honeymoon
Success. Distance: 0.00

/dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES (14 items)
Tagging:
    Lana Del Rey - Honeymoon
URL:
    http://musicbrainz.org/release/11f77c97-fbd0-463b-b71d-ba1fcdd1d933
(Similarity: 100.0%) (Digital Media, 2015, US, Interscope Records)
 * Music To Watch Boys To        -> Music to Watch Boys To
 * High By The Beach             -> High by the Beach
 * Burnt Norton (Interlude)      -> Burnt Norton (interlude)
 * Don't Let Me Be Misunderstood -> Don’t Let Me Be Misunderstood
Sending event: import_task_choice
Sending event: import_task_apply
0 of 14 items replaced
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
fetchart: trying source coverart for album Lana Del Rey - Honeymoon
artresizer: method is (2, (6, 7, 7))
fetchart: downloading image: http://coverartarchive.org/release/11f77c97-fbd0-463b-b71d-ba1fcdd1d933/front
fetchart: downloaded art to: /tmp/tmpTTeeTj.jpg
fetchart: using remote image /tmp/tmpTTeeTj.jpg
artresizer: ImageMagick resizing /tmp/tmpTTeeTj.jpg to /tmp/tmpM3eR1Q.jpg
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/01-lana_del_rey-honeymoon.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/01-lana_del_rey-honeymoon.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/04-lana_del_rey-god_knows_i_tried.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/04-lana_del_rey-god_knows_i_tried.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/14-lana_del_rey-dont_let_me_be_misunderstood.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/14-lana_del_rey-dont_let_me_be_misunderstood.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/08-lana_del_rey-burnt_norton_(interlude).flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/08-lana_del_rey-burnt_norton_(interlude).flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/10-lana_del_rey-salvatore.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/10-lana_del_rey-salvatore.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/11-lana_del_rey-the_blackest_day.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/11-lana_del_rey-the_blackest_day.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/07-lana_del_rey-art_deco.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/07-lana_del_rey-art_deco.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/05-lana_del_rey-high_by_the_beach.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/05-lana_del_rey-high_by_the_beach.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/13-lana_del_rey-swan_song.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/13-lana_del_rey-swan_song.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/09-lana_del_rey-religion.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/09-lana_del_rey-religion.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/06-lana_del_rey-freak.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/06-lana_del_rey-freak.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/03-lana_del_rey-terrence_loves_you.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/03-lana_del_rey-terrence_loves_you.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/12-lana_del_rey-24.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/12-lana_del_rey-24.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
convert: Encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/02-lana_del_rey-music_to_watch_boys_to.flac
convert: Finished encoding /dunehd/Musica pendiente/Lana_Del_Rey-Honeymoon-CD-FLAC-2015-VOLDiES/02-lana_del_rey-music_to_watch_boys_to.flac
Sending event: write
zero: comments: <-> Released by VOLDiES <-> -> None
Sending event: after_write
Sending event: database_change
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: item_copied
Sending event: database_change
Sending event: database_change
Sending event: write
zero: comments:  -> None
Sending event: after_write
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: database_change
Sending event: import_task_files
Sending event: art_set
Sending event: database_change
Sending event: album_imported
Sending event: import
Sending event: cli_exit

@sampsyo sampsyo changed the title (convert plugin) 'embed: yes' doesn't embed the album art convert: embed setting not respected on import (in auto mode) Nov 1, 2015
@sampsyo sampsyo added bug bugs that are confirmed and actionable and removed needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." labels Nov 1, 2015
@sampsyo
Copy link
Member

sampsyo commented Nov 1, 2015

Thanks for doing the full investigation. After looking into the code, it is true that the embed setting isn't respected at all for the auto hook. Unfortunately, this will be a nontrivial fix—since finding the right album art to embed is the purview of the fetchart plugin, we'll need to find some way for the two to interact felicitously.

The eventual solution may also depend on the embedart plugin enabled in auto mode.

@JDLH
Copy link

JDLH commented Jul 18, 2016

Issue #2116 might be related. It has to do with resizing album art during a convert operation. The underlying common issue might be that beets does the "same" action differently depending on which command invokes the plugin. FYI.

@sampsyo
Copy link
Member

sampsyo commented Jul 18, 2016

They're actually separate bugs, but it might be possible to address both in a "two birds with one stone" scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

3 participants