-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-numeric track indices #1831
Comments
Yep! Sounds reasonable. It's of course contingent on file formats supporting this kind of data. Another thorny issue is how we'd support both the common case (numbers stored as actual numbers, sorted numerically so 10 appears after 9) and the non-numeric case (stored as strings, sorted as strings, queried using substring search, etc.) without confusing the two. |
Sounds like an useful addition indeed! Some preliminary look at the specifications (help would be appreciated in checking the rest of the formats):
Leaving aside the database/ordering/confusion considerations raised by @sampsyo on the previous comments for a moment and going back to the I have little experience with vinyls, but I believe that both sides of a vinyl are usually considered the same medium (on MB, etc) - ie. a vinyl with 2 tracks on side A and 1 on side B would be listed as one medium, with tracks labelled |
Here's another idea (I haven't checked yet whether any other software does this): Keep the track-number field numeric, for ordering purposes, and invent a second field for the "human-readable" version of the track number. This would be a string, and it would be solely for cosmetic purposes---sorting and querying wouldn't be affected. |
In general vinyl "rips" in the wild have been tagged with artist, track name, release name and the files intrinsically have durations. They usually have track numbers, even if those are all "0", arbitrary numeric or the correct non-numeric or alpha-numeric designations. I think this is our best chance during this pre-import phase. It is, in my experience, rare for files to have subdirectories per side. Also, as you say, in MB both sides of one vinyl are a single medium. Per #musicbrainz IRC, Vorbis and ape2 allow for anything, while "qt comments allow numbers only but for some reason can store them" such that iTunes "won't display them, but it will sort properly". Per the same person, "all the casette/vinyl rips I have have tracks named A, B or A1, A2, B1, B2." |
Thanks a lot for sharing your impressions and for taking the time to contact #musicbrainz via IRC, @awesomer! It helps me getting a better picture of the vinyl "conventions" and it's a great pointer towards filling up the file format support list.
I like the idea, if only because modifying the existing |
Anything obvious from not adding another field called For example, here is an XML snippet for track Near Dark by artist Agathodaimon.
And here is the same track retrieved from Discogs in JSON.
Putting aside the difference between both sources using different track positions (e.g. MusicBrainz would use XML value Thoughts? |
I forked |
Cool! Perhaps you could open a pull request, @lengtche? |
Looks like this can be closed now? |
Yes, thanks! |
While the original request asked for support for Musicbrainz and Discogs, I'm fine with Discogs support being the request of someone who uses the Discogs plugin. :D thanks to @lengtche for the contribution! awesome! |
When using the [P] option from #1689, I noticed this discrepancy :
vs. existing mb tracklist :
A. Ride My Junk (Squarehead mix) - Waze & Odyssey (?:??)
B. Ride My Junk (Chamboche remix) - Waze & Odyssey (?:??)
http://musicbrainz.org/release/af714e5d-6cbb-497e-a495-868141eff541
I spoke briefly with sampsyo about it, he said that I should file this issue, to request support for non-numeric track identifiers :
The text was updated successfully, but these errors were encountered: