-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide pre-import means of printing file tags in mb release editor tracklist format #1689
Comments
Seems like a good way to contribute back to MB. Forgive my ignorance, but what does the preferred track list format look like? Does it get pasted into somewhere? And is there something special about how the lengths need to be formatted? |
Example :
http://musicbrainz.org/release/69624900-feeb-4d91-8d98-b75c5a808704 One pastes it into the "track parser" on the "tracklist" page of the musicbrainz release editor. |
Got it. Looks like this (old) wiki page describes the track parser you're using, right? A good first step, should anyone choose to accept it, would be to extend the |
Now that custom formatting for the As far as I can see, steps 2 and 3 on the original flow proposed by @awesomer seem to call for adding a plugin listener in the proper place (as-is choice or music brainz query with empty results), but I'm not sure if it would be a good idea to add that functionality to the On a (very marginal) side note, I'm wondering if it might be a good idea to come up with a system (in case it is not already in place or already discussed) to allow plugins to modify the options presented to the user during |
I concur with all your observations! Namely:
|
I have used the recently merged version. I have "mbsubmit" in my plugins, and I've seen the [P]rint and sKip options and used them successfully. However, I am trying to get them to always display, and have : mbsubmit:
threshold: none In my config.yaml, which according to the documentation should remove any threshold for match quality to check for displaying these options. I then re-import the release I want to import durations for, and I do not see these options displayed. Am I misunderstanding the threshold option? My use case is wanting to add durations to musicbrainz vinyl rip tracklists by printing their beets duration. Edit : sigh, of course immediately after typing this out I decided to try "strong" and it worked as expected. I guess I didn't understand why one would want to have the plugin enabled but not ever displays these options? Shouldn't one just disable the plugin if one doesn't want the options displayed? Edit 2: I also have this problem with the default path format :
vs. existing mb tracklist : A. Ride My Junk (Squarehead mix) - Waze & Odyssey (?:??) I looked at the path formats and didn't see any variation of "track" that seemed likely to print "A." and "B."? Any ideas? |
Thanks for trying it out and for the feedback!
Glad you have been able to sort it out - as you probably inferred, As for the rationale, the main idea was to avoid "polluting" the prompt as discussed at #1779 (comment), as I personally felt the most common case was that the user would only use it for a handful of albums (the ones that do not have a proper MB match) during an import session, and if other plugins start adding choices to the prompt it might get a bit out of hand quickly. I'd gladly revise the decision if there is a consensus on it, as it was mainly a personal opinion and prediction!
Hmm, the way the plugin works is that it simply prints the information found on the This implies that unless the files do actually have "A1", "B", etc on their track number tag (which I'm actually not sure if it is a valid value for most of the formats - they might be forced to be numeric), the plugin currently has no way of knowing how to map the numbers to the vinyl naming, and it makes no effort to do so as it "assumes" that the mediafile tags are right and accurate. Unfortunately I can't think of a solid and reliable way of working around this issue, but if a solution is found I'd be happy to work on it. |
That makes perfect sense. For now I'll just fix the track names on durationless vinyl rips manually. I do plan to file an issue regarding support of non-numeric tracknames, for the containers that support it. :D |
@diego-plan9 : fyi, I have filed #1831 for support of non-numeric track identifiers. :D |
Closing this ticket, since |
Feature request.
Beets could be enhanced to make it easier to add the tracklists of new releases to musicbrainz. Currently one has to import the release with tags as is, and then re-tag.
https://gist.github.com/DjSlash/3313266de1b696667725#file-config-yaml-L65
Has an example of how DjSlash created a "nicelength" such that one can print a tracklist in this format. This would be especially handy when importing durations of one's vinyl recordings.
Import workflow would be :
The text was updated successfully, but these errors were encountered: