mbsubmit: cleanup and completion #1779
Conversation
* Cleanup the "mbsubmit" plugin to remove a choice ("print tracks and skip")
and make the logic depend on the strength of the Recommendation.
* Add configuration options for the Recommendation threshold that triggers
the addition of the "Print tracks" choice and for the formatting string to
be used for printing the items.
* Include link to the official-ish MusicBrainz format page on the docstring.
* Add basic unit tests for the mbsubmit plugin, covering the output of the "Print tracks" option on albums and singletons.
| 'threshold': 'medium', | ||
| }) | ||
|
|
||
| # validate and store threshold |
There was a problem hiding this comment.
We tend to format comments as "full sentences" in beets—starting with a capital letter and ending with a period.
|
Awesome; this looks perfect. Feel free to merge at will. On those questions:
|
|
Thanks for the quick turnaround, and commenting on the questions - sounds like a reasonable compromise. I will work on the documentation during tomorrow and hopefully everything should be ready for a merge soon! |
|
Fixed the style issues, and added some pretty basic documentation and a changelog entry. As usual, double checking the documentation would be more than welcome! |
| As MusicBrainz currently does not support submitting albums programmatically, | ||
| the recommended workflow is to copy the output of the ``Print tracks`` choice | ||
| and paste it into the parser that can be found by clicking on the | ||
| "`Track Parser`" button on MusicBrainz "`Tracklist`" tab. |
There was a problem hiding this comment.
Any particular reason for the extra backticks here? It seems like quotes might be enough. (This is officially the tiniest style issue ever!)
|
This looks great! I made some extremely minor suggestions in the docs, but I think this is ready—feel free to merge this whenever you're happy with it. Woohoo! 🎉 |
diego-plan9
force-pushed
the
prompthook
branch
from
d6a25db
to
cd225ca
Compare
Conflicts: docs/changelog.rst
diego-plan9
force-pushed
the
prompthook
branch
from
cd225ca
to
75636a2
Compare
|
Fixed the style issues (the extra ticks were for making it more evident that they were referring to the names of the button/elements on MusicBrainz site, and the choice of I have also merged upstream/master, solving the tiny conflict on |
mbsubmit: cleanup and completion
|
And merged, after the checks seemed ok! |
|
Woohoo! |
Updates beets to version 1.3.16, which comes with new plugins "embyupdate", "edit" and "mbsubmit". See the following URL for a detailed upstream changelog: http://beets.readthedocs.org/en/v1.3.16/changelog.html The "mbsubmit" plugin isn't listed there and made it more or less silently into the release, see beetbox/beets#1779 for the final work on the plugin. Tested this locally with a few queries and using the new "edit" plugin.
Glad to see a new release has been made!
I'm getting back to work on beets after a few days away from the computer, hopefully bringing issue #1689 to a close eventually. As hinted on the previous discussion, this pull request is intended to take care of the
mbsubmitplugin cleanup, now that the underlying pieces are in place.I have modified a bit the behaviour, making the decision of appending the
"Print tracks"choice depend solely ontask.rec. The default behaviour is to only append the choice to matches where the recommendation is equal or lower thanRecommendation.medium, which hopefully covers the most obvious choices (albums with no matches, albums with weak-ish matches) and the original request by @awesomer, and also avoids polluting the prompt in the cases where the match is strong. A config option has been added that allows the user to modify this settings (extra-picky users might find it useful to always be able to print tracks for fixing spelling mistakes, other users might only want it on albums with no matches, etc).Other than that, a configuration option for setting the format string has been added as well - I can't think of a case where this might come in handy currently, but maybe more creative users might find it useful.
A couple of notes:
fromfilename, etc) in those cases?strong, but launches the importer in non-timid mode, the prompt will not actually be displayed. Would a note on the (upcoming) documentation suffice, as handling this case probably requires some changes that seem to be a bit out of the scope of the plugin?As usual, any comments and input are more than welcome!