Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchart python3 compatibility when using itunes #2371

Closed
PierreRust opened this issue Jan 6, 2017 · 2 comments
Closed

fetchart python3 compatibility when using itunes #2371

PierreRust opened this issue Jan 6, 2017 · 2 comments
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."

Comments

@PierreRust
Copy link
Contributor

Problem

This not exactly a problem on beets it-self, but when using fetchart on a python 3 installation it fails on itune import as the module used is compatible with python 3

Running this command:

 beet fetchart genre:Classical

Led to this problem:

** error loading plugin fetchart:
Traceback (most recent call last):
  File "/home/pierre/.env_beets/lib/python3.5/site-packages/beets/plugins.py", line 254, in load_plugins
    namespace = __import__(modname, None, None)
  File "/home/pierre/.env_beets/lib/python3.5/site-packages/beetsplug/fetchart.py", line 39, in <module>
    import itunes
  File "/home/pierre/.env_beets/lib/python3.5/site-packages/itunes/__init__.py", line 94
    except urllib2.HTTPError, e:

Of course, the best solution (and probably only solution, except patchin python-itunes) is not to use itune as a source at all. I could be enough to mention this in the documentation.

@sampsyo
Copy link
Member

sampsyo commented Jan 6, 2017

Hmm; did that traceback get cut off? Looks like we're missing the all-important last line.

And yeah, on first glance it looks like that module is not py3-compatible. We should make it an optional import (if it's not already) and add a note to the docs.

@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Jan 6, 2017
@ghost
Copy link

ghost commented Jan 6, 2017

I didn't even know we imported another module. I took the list in setup.py for plugin deps as gospel. I guess that was wrong. :( I guess it's time to do a search for all imports.

owcz added a commit to owcz/beets that referenced this issue May 3, 2017
The plugin is inactive and has been broken for months: beetbox#2371

Fixes beetbox#1610
nathdwek pushed a commit that referenced this issue Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."
Projects
None yet
Development

No branches or pull requests

2 participants