Incorrect ReplayGain tag writing for AAC files #2426
Labels
bug
bugs that are confirmed and actionable
Comments
|
In the future, please use code brackets surrounding pastes from the terminal (i.e., three backticks at the top and bottom), which makes things much more readable. It looks like this is the important part. The "before" output: and the "after" output: Something happened to the album gain/peak values. I'll investigate further. |
sampsyo
added
the
needinfo
|
I apologize. I'll go clean up the bug.
…On Wed, Feb 1, 2017 at 11:42 AM, Adrian Sampson ***@***.***> wrote:
In the future, please use code brackets surrounding pastes from the
terminal (i.e., three backticks at the top and bottom), which makes things
much more readable.
It looks like this is the important part. The "before" output:
rg_album_gain: -8.51
rg_album_peak: 1.000031
rg_track_gain: -10.28
rg_track_peak: 1.000031
and the "after" output:
rg_album_gain: 1.000031
rg_album_peak: 1.000031
rg_track_gain: -10.28
rg_track_peak: 1.000031
Something happened to the album gain/peak values. I'll investigate further.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2426 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADPlXswzVksrXxAcWAEQp6v2r6UY2dmbks5rYLXmgaJpZM4Lz_mw>
.
|
|
Awesome; thank you! ✨ |
|
Is that better? |
|
Yes; thank you! |
|
The bug is marked as "needinfo." Are you waiting on something from me? |
|
Nope, it was just waiting for me to reproduce the problem. From some initial tests, it looks like this might be a more general problem—not necessarily related to Thanks! |
sampsyo
changed the title
sampsyo
added
bug
|
Sure. I can do some testing. I'll get back to you later today.
Andy
…On Sat, Feb 4, 2017 at 2:55 PM, Adrian Sampson ***@***.***> wrote:
Nope, it was just waiting for me to reproduce the problem.
From some initial tests, it looks like this might be a more general
problem—not necessarily related to convert. Do you have any AAC
files in your beets library? If so, can you check whether it's
possible to use beet modify rg_album_gain to even manually change
their album gain level? That is, if you make this change, does the
change show up in beet info or foobar2000 or anywhere else?
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
sampsyo
added a commit
that referenced
this issue
Feb 4, 2017
I'm not sure how this got messed up, but this was: - Trying to store album gain in the track peak part of the SoundCheck tag! - Not writing the album gain to the non-SC free-form RG tag! Together, this led to serious weirdness when writing these fields on AAC files. To be clear, we currently *only* support track-level data for SoundCheck. We also record album-level RG information in non-iTunes tags, but that's separate. A little googling suggests that SoundCheck now has album-level data, but supporting that is a separate issue.
|
Great; thanks! In fact, as an update: l did a little more digging and tracked the bug down to the way that we're manipulating RG tags on AAC files. I've just pushed a fix for that, so this may actually be totally cleared up. So if you can, please get the latest source and try your |
|
So, here's a beet info on a iTunes track I purchased and imported into beets. |
|
Reimported again to make sure the latest version of beets tagged it: |
|
OK! I'm not totally sure what to look for in these outputs… are there expected values for the SoundCheck data generated by iTunes? |
|
I haven't tried the new commit yet. You beat me to posting my beet info output. I'll give it a try. I assume I need to compile from source, and can't just do an updated through pip? |
|
An ordinary |
|
Ok, retagged the above aac song that was in my library. Here are the results: Need to tinker some more, but it looks like it's fixed! |
|
FooBar2000 is seeing album gain data! Marking this closed. Thank you for fixing this! |
|
Yay! Thanks for giving that a try. |
|
This bug has another effect. With every |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
I used beets convert to convert my music library from FLAC to AAC using ffmpeg and libfdk_aac. The following command is being used to do the conversion in the config.yaml.
command: ffmpeg -i $source -c:a libfdk_aac -b:a 256k $dest
It appears album gain information is being written improperly. album gain, album peak, and track peak values are identical, and foobar2000 claims the files have no album gain info.
Running this command in verbose (
-vv) mode:beet info on the track Roller Coaster:
AAC File beet info
Led to this problem:
Here's a link to the music files that trigger the bug (if relevant):
Setup
My configuration (output of
beet config) is:The text was updated successfully, but these errors were encountered: