Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of a multidisc release is broken if it has subdirectories #2493

Closed
antlarr opened this issue Mar 25, 2017 · 1 comment
Closed

Import of a multidisc release is broken if it has subdirectories #2493

antlarr opened this issue Mar 25, 2017 · 1 comment
Labels
bug bugs that are confirmed and actionable

Comments

@antlarr
Copy link
Contributor

antlarr commented Mar 25, 2017 •
edited
Loading

Problem

I have a directory structure like:

/music/artist/album/CD1/*.mp3
/music/artist/album/CD1/info/*.txt
/music/artist/album/CD1/covers/*.jpg
/music/artist/album/CD2/*.mp3
/music/artist/album/CD2/info/*.txt
/music/artist/album/CD2/covers/*.jpg
/music/artist/album/CD3/*.mp3
/music/artist/album/CD3/info/*.txt
/music/artist/album/CD3/covers/*.jpg

When importing such a directory structure with beets, the importer doesn't
collapse the paths since it has subdirectories that "break" the pattern matching.
All the contents of CD1/CD2/CD3 directories should be colllapsed into the same release, as the documentation says :

First, directories that look like separate parts of a multi-disc album are tagged
together as a single release. If two adjacent albums have a common prefix,
followed by “disc,” “disk,” or “CD” and then a number, they are tagged together.

Setup

  • OS: openSUSE Tumbleweed
  • Python version: 3.6
  • beets version: git master
antlarr added a commit to antlarr/beets that referenced this issue Mar 25, 2017
@antlarr
Fix import of multidisc releases with subdirectories
47cc959 
Don't stop collapsing paths when iterating over subdirectories of
already collapsed paths.

Fixes beetbox#2493
@antlarr antlarr mentioned this issue Mar 25, 2017
Merged
@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Mar 26, 2017
@sampsyo
Copy link
Member

sampsyo commented Mar 26, 2017

Agreed; I can't see any reason not to collapse those paths with subdirectories. Maybe it would be nice to avoid collapsing if those subdirectories also contain music? I'm not certain—perhaps that will never be a problem.

antlarr added a commit to antlarr/beets that referenced this issue May 8, 2017
@antlarr
Fix import of multidisc releases with subdirectories
9efa9c5 
Don't stop collapsing paths when iterating over subdirectories of
already collapsed paths.

Fixes beetbox#2493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sampsyo @antlarr