Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discogs: Fetch "style" field #2579

Closed
brendan-pike opened this issue May 29, 2017 · 12 comments · Fixed by #3251
Closed

discogs: Fetch "style" field #2579

brendan-pike opened this issue May 29, 2017 · 12 comments · Fixed by #3251
Labels
feature features we would like to implement

Comments

@brendan-pike
Copy link

Can beets please be enhanced to pull music style in addition to Genre. In my opinion discog have the most intelligent music categorising system available. So if like me you wish to follow this it is impossible without styles. Discog only have 15 genres but 425 styles.

As an example if we search Bob Dylan - Fallen Angels we see its associated with three genres: Rock; Blues; Pop and one style: Vocal. The Vocal style is a "sub-genre" of Pop.

To my knowledge the Discog API does not support probing this genre/style relationship structure unfortunately but simply provides the tags to each album. So in my opinion it would be adequate for at least now to simply start recording album styles simply as a STYLE metatag against each track. This is what currently manually do, so for our Fallen Angels example I would simply have the following ```

genre="Rock; Blues; Pop"
style="Pop"

Initially I would like the ability to automatic this process from Beets.

If there was is a way Beets is able to build on this in the future then even better. I would for example to be able to see what albums in my collection have a style of Vocal and genres that include "Folk, World, & Country".

Thank you

How to store this information within Beets

@sampsyo sampsyo added the feature features we would like to implement label May 29, 2017
@sampsyo sampsyo changed the title Feature Request: Pull style from discog discogs: Fetch "style" field May 29, 2017
@sampsyo
Copy link
Member

sampsyo commented May 29, 2017

Thanks for filing the request!

(See also #465.)

@dbogdanov
Copy link
Contributor

I am also voting for this feature. Discogs provides the best public data that can be used for annotation by styles (subgenres) out there.

@thedevilisinthedetails
Copy link

So I managed to get this working. I didnt add the additional feature req from #465 as I wanted to focus more on just the styles. Its grabbing all style tags from discogs for the specific album chosen and applying it as so; "style1 - style2 - style 3 - etc". If this is ok I can make a PR. Let me know

@jackwilsdon
Copy link
Member

All feature PRs are welcome @thedevilisinthedetails! Sounds like a great addition to beets.

@thedevilisinthedetails
Copy link

Cool, noticed a slight bug i created. Will fix then make the PR

@montchr
Copy link

montchr commented May 1, 2019

I would love to see this feature @thedevilisinthedetails!

Its grabbing all style tags from discogs for the specific album chosen and applying it as so; "style1 - style2 - style 3 - etc".

Could you consider adding a configurable setting to determine whether to write all style tags (as you suggested) or just the first style listed?

@dbogdanov
Copy link
Contributor

Btw, how are multi-genres treated? The format for style strings should be consistent with that.

@thedevilisinthedetails
Copy link

thedevilisinthedetails commented May 5, 2019

I would love to see this feature @thedevilisinthedetails!

Its grabbing all style tags from discogs for the specific album chosen and applying it as so; "style1 - style2 - style 3 - etc".

Could you consider adding a configurable setting to determine whether to write all style tags (as you suggested) or just the first style listed?

Hmm, thing is I am currently sorting the styles by alphabetical order. So if style tags are: "Industrial, Techno, Ambient", the output would be "Ambient - Industrial - Techno". I figured this way users can create atree type directory structure in their config file.

I really want to get this PR out there but it seems I am having issues pushing my branch into the repo. Will work on this today and get the PR open

@thedevilisinthedetails
Copy link

Btw, how are multi-genres treated? The format for style strings should be consistent with that.

I think the discogs plugin is not working with genres. I always use discogs to tag my mp3s and the genre tagged does not seem to be consistent to what is on discogs. Seems to always be defaulted with the lastgenre plugin. I have no idea how it's working within lastgenre.

@thedevilisinthedetails
Copy link

thedevilisinthedetails commented May 5, 2019

PR opened; test failing though. Will fix

@dbogdanov
Copy link
Contributor

For the LastGenre plugin it is said that "the genres are separated by commas by default, but you can change this with the separator config option."

It may be useful to have a similar option for consistency (different users may prefer different separators, and they may want them to be consistent across different annotation plugins they use).

@thedevilisinthedetails
Copy link

This weeked will address the comments, change hypens to commas and adjust test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants