-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicates
plugin thinks there is a duplicated recording in an album with actually a duplicated recording.
#2690
Comments
Interesting point! I'd be interested to hear more thoughts on exactly how this should work. The current algorithm for the How should an algorithm work that respects the fact that some duplicates might be intentional? It's not completely clear to me how this would work—or how we could make it efficient, without querying the MBWS for every album. |
Well I think that even if we only check the |
Hmm… if that's enough, may I recommend just adding That should consider items with different |
OK.., I had no idea I can configure all of these options, it's great, but still there is one question that should bother us: We can see that the different tracks which are reported as duplicates are: https://musicbrainz.org/track/a3b6d068-0c45-32c1-afe7-dcedf24407fa Both have a different ID. Are those supposed to be the values of |
Yes. For historical reasons, mb_trackid actually holds the recording ID. See also #406. |
Hmm, it seems no one responded @mineo's #406 (comment) which asserts pretty much what I was saying as well. I think a PR should be made. |
Indeed! Any help would be appreciated. |
Is |
Nope, we don't have a field by that name. The recording ID goes in |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Problem
There are releases in the musicbrainz database which actually have a certain recording multiple times and this causes the
duplicates
plugin report these recordings are as duplicated. I'll examine with the following example:This release by Frank Sinatra:
Three Original Hit Albums
, has the recording of the trackI Get Along Without You Very Well
twice, as you can see in this and this tracks.IMO, the
duplicates
plugin should check before reporting whether or not these tracks appear in the database twice as well as within the local files.The text was updated successfully, but these errors were encountered: