Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the musicbrainz_releasetrackid tag #406

Closed
mineo opened this issue Oct 8, 2013 · 8 comments
Closed

Add the musicbrainz_releasetrackid tag #406

mineo opened this issue Oct 8, 2013 · 8 comments
Labels
feature features we would like to implement

Comments

@mineo
Copy link
Contributor

mineo commented Oct 8, 2013

We decided to call it musicbrainz_releasetrackid at the summit (https://wiki.musicbrainz.org/MusicBrainz_Summit/13#Elephant_IDs). The commit adding it to Picard is metabrainz/picard@04c3035 so you can just reuse the tag names for all the different formats.

@sampsyo
Copy link
Member

sampsyo commented Oct 8, 2013

Looks great; we should definitely add this.

We can also consider following Picard's lead and changing our internal recording ID name from mb_trackid to mb_recordingid (although this would be a bit of a DB migration headache).

@mineo
Copy link
Contributor Author

mineo commented Apr 21, 2014

Something that I just thought about because people were talking about duplicates in #mb: if this gets implemented, it would be a good idea to have the duplicates plugin check this tag instead of mb_trackid in https://github.com/sampsyo/beets/blob/master/beetsplug/duplicates.py#L116 because mb_trackid is not really a good indicator for duplicate files.

@mineo
Copy link
Contributor Author

mineo commented Oct 7, 2014

I'm not sure how up to date the bpd plugin is with compatibility to the real MPD, but the real one will support this tag in 0.19 (http://git.musicpd.org/cgit/master/mpd.git/commit/?id=5525ea45a4e1765db110a8ca5abbc3ca5e66a89a).

@Rawrmonkeys
Copy link
Contributor

What is the status on this? I see that #2690 has some discussion.

Is there anything getting in the way of adding support for the musicbrainz_releasetrackid tag and tossing the possible DB change of mb_trackid -> mb_recordingid into it's own issue?

@sampsyo
Copy link
Member

sampsyo commented Mar 19, 2018

Yep, just adding the recording ID would be totally fine. Any help would be appreciated.

@Rawrmonkeys
Copy link
Contributor

You mean the release track id?

@sampsyo
Copy link
Member

sampsyo commented Mar 20, 2018

Oops, yes!

@arcresu
Copy link
Member

arcresu commented Apr 25, 2019

It looks to me like this has been implemented and can be closed now, so I'll do so. If I've missed something and that's not the case, please repoen this or leave a comment :)

@arcresu arcresu closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants