-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbsync: Tolerate MusicBrainz recording ID changes #1234
Comments
On recording merges (which I would estimate are somewhat more common than other kinds of merges), looking up a merged MBID should return the "new" canonical MBID in the WS response, which would mean that |
It's not just merge and delete which could cause this though. If a track points to a wrong recording, and this is fixed in musicbrainz by pointing to the correct recording, both recording are still present. Fetching information for the old recording id in this case does not help us at all in getting the new one, similar to the delete case. |
Track IDs as a fallback seem fine, I think. Track/disc position seem dicier—it would be a good goal to keep "guesswork" out of |
Fixes beetbox#1234 by following recording MBIDs changes.
mbsync uses the musicbrainz recording id to match local track information against a certain track in a musicbrainz release. However, there is no fallback matching defined, so once the recording id changes in musicbrainz the local track can no longer be synced unless the recording id is changed manually. But this behavior is also not very visible (I stumbled upon it by accident), so most users would not even be aware that the recording id is outdated.
The text was updated successfully, but these errors were encountered: