Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmusic: Automatically Upload to Google Music on Import #2997

Closed
shuaiscott opened this issue Aug 5, 2018 · 8 comments
Closed

gmusic: Automatically Upload to Google Music on Import #2997

shuaiscott opened this issue Aug 5, 2018 · 8 comments
Labels
feature features we would like to implement

Comments

@shuaiscott
Copy link
Contributor

Feature Request

Uploading all my current music via Beets would result in a lot of duplicate entries. It'd be nice to have the functionality to automatically upload to Google Music when new items are added to the library

@sampsyo sampsyo changed the title Automatically Upload to Google Music on Import gmusic: Automatically Upload to Google Music on Import Aug 5, 2018
@sampsyo
Copy link
Member

sampsyo commented Aug 5, 2018

Sounds good! Any hackers in the gmusic plugin are hereby invited to pitch in. 😇

@sampsyo sampsyo added the feature features we would like to implement label Aug 5, 2018
@shuaiscott
Copy link
Contributor Author

Took a look at how this would've been implemented and decided to knock it out real quick 😄

@jsetton
Copy link

jsetton commented Jan 10, 2019

@shuaiscott thanks for implementing this change. However, I noticed that the files uploaded during the import are missing some of the metadata updates made by other plugins such as album art images or featured artists added to title. Do you think it would be possible for the upload to happen after all the plugins interacting with the metadata are done?

@shuaiscott
Copy link
Contributor Author

shuaiscott commented Jan 29, 2019

@jsetton Yeah, I think I noticed this too on my own auto-uploads. However, looking through the docs, it appears that plugins run all at the same time in parallel... meaning that while trying to get artwork and lyrics and etc, it will be uploading to Google Music at the same time. Might be best to just manually upload to Google after all, unless another post-processing plugin feature is added to beets.

@shuaiscott
Copy link
Contributor Author

@jsetton I just tried importing a new song with auto upload turned off. It too was missing some metadata and artwork. Maybe there's something going on with the Python library or with Google's upload service

@jsetton
Copy link

jsetton commented Jan 29, 2019

@shuaiscott Related to the auto upload feature, based on my understanding, you can register the process to run after a specific event. The downside is that it would be a blocking call compared to just having that process run asynchronously during the import stages.

Anyway, I have since moved away from gmusicapi and started to use a new google-music api wrapper via a shell script.

@shuaiscott
Copy link
Contributor Author

Wow, I didn't realize that was built into plugins now. I'll reopen this and hopefully get this added to auto import after the whole import flow is run.

self.register_listener('import', self.autoimport)

@wisp3rwind
Copy link
Member

Closing, since there's no more Google Play Music: #4089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants