Adding gmusic ability to upload on import #2998
Conversation
Adding auto parameter info to explain usage and functionality of importing all tracks to Google Play Music
beetsplug/gmusic.py
Outdated
| self.config.add({ | ||
| u'auto': False, | ||
| }) | ||
| if self.config['auto'].get(bool): |
There was a problem hiding this comment.
The .get(bool) bit is not actually necessary here—configuration views get coerced to Booleans automatically.
beetsplug/gmusic.py
Outdated
| @@ -62,6 +68,14 @@ def upload(self, lib, opts, args): | |||
| self.m.upload(filepaths=files) | |||
| ui.print_(u'Your files were successfully added to library') | |||
|
|
|||
| def autoupload(self, session, task): | |||
| items = task.imported_items() | |||
| files = [x.path.decode('utf-8') for x in items] | |||
There was a problem hiding this comment.
Although I know it’s what the code above does too, this decode call is pretty worrisome and will probably break on some inevitable non-UTF-8 filenames. Can we please factor this out into a helper function so it’s possible to fix both at once?
beetsplug/gmusic.py
Outdated
| ui.print_(u'Uploading your files to Google Play Music...') | ||
| self.m.upload(filepaths=files) | ||
| ui.print_(u'Your files were successfully added to your ' | ||
| + 'Google Play Music library') |
There was a problem hiding this comment.
Using print_ during the import process is likely to interrupt some interactive prompts and such. It’s probably best to use the plugin’s log to emit this output while hiding it by default.
* Fixes based on review and changelog addition
beetsplug/gmusic.py
Outdated
| self._log.info(u'Uploading files to Google Play Music...', files) | ||
| self.m.upload(filepaths=files) | ||
| self._log.info(u'Your files were successfully added to your ' | ||
| + 'Google Play Music library') |
There was a problem hiding this comment.
Travis has a silly whitespace complaint about this line:
https://travis-ci.org/beetbox/beets/jobs/412848100
|
Nice work; thank you! |
Implemented the import_stages def on gmusic and updated the docs
#2997