Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split release and release-group disambiguation into separate fields #3024

Closed
djl opened this issue Sep 4, 2018 · 2 comments
Closed

Split release and release-group disambiguation into separate fields #3024

djl opened this issue Sep 4, 2018 · 2 comments
Labels
feature features we would like to implement

Comments

@djl
Copy link
Member

djl commented Sep 4, 2018

Back in #87, @sampsyo mentioned that the two disambiguation fields beets uses may need to be split into separate fields. Five and a half years later, I agree!

As it stands, some albums (like the Weezer albums mentioned in the pull request) have doubled disambiguation fields:

$ beet ls -a -f '$albumatist - $album [$albumdisambig]' weezer ^albumdisambig::^$
Weezer - Weezer [Green Album, Green Album]
Weezer - Weezer [Red Album, Red Album]
Weezer - Weezer [Blue Album, Blue Album, BMG club release]

This ugliness keeps me awake at night.

Opening this as a tracking issue until I (or someone else) can find time to fix this.

@sampsyo
Copy link
Member

sampsyo commented Sep 5, 2018

Argh; yeah, that result isn't very pretty at all. Splitting these two fields (and making $albumdisambig itself more sensible in the process) seems like the thing to do.

@sampsyo sampsyo added the feature features we would like to implement label Sep 5, 2018
@djl
Copy link
Member Author

djl commented Sep 5, 2018

Fixed in #3025.

@djl djl closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

2 participants