Split release and release-group disambiguation into separate fields. #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Sep 5, 2018
beets/autotag/hooks.py
Outdated
| @@ -66,6 +66,7 @@ class AlbumInfo(object): | |||
| - ``albumstatus``: MusicBrainz release status (Official, etc.) | |||
| - ``media``: delivery mechanism (Vinyl, etc.) | |||
| - ``albumdisambig``: MusicBrainz release disambiguation comment | |||
| - ``releasegroupdisambig``: MusicBrainz release group disambiguation comment | |||
There was a problem hiding this comment.
Travis has the most nitpicky style nitpick ever on this line: https://github.com/beetbox/beets/pull/3025/files
| @@ -346,13 +346,11 @@ def album_info(release): | |||
| info.releasegroup_id = release['release-group']['id'] | |||
| info.albumstatus = release.get('status') | |||
|
|
|||
| # Build up the disambiguation string from the release group and release. | |||
There was a problem hiding this comment.
Maybe preserving a version of this comment would be useful; for example:
Get the disambiguation strings at the release and release group level.
|
Addressed the comments and made Travis green again. |
|
Perfect; thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a pretty rough first attempt at fixing #3024.
releasegroupdisambigseems needlessly long but it does follow the naming conventions of other fields.