-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importer displays misleading info on album with track 0 #3346
Labels
bug
bugs that are confirmed and actionable
Comments
Do you enable the diff --git a/beets/ui/commands.py b/beets/ui/commands.py
index 53253c1d..5ad264a8 100755
--- a/beets/ui/commands.py
+++ b/beets/ui/commands.py
@@ -241,7 +241,7 @@ def show_change(cur_artist, cur_album, match):
if mediums and mediums > 1:
return u'{0}-{1}'.format(medium, medium_index)
else:
- return six.text_type(medium_index or index)
+ return six.text_type(medium_index if medium_index is not None else index)
else:
return six.text_type(index) |
I did enable that option: my config:
|
wisp3rwind
added a commit
to wisp3rwind/beets
that referenced
this issue
Aug 19, 2019
fixes issue beetbox#3346: For (hidden) tracks with index 0, the UI would previously show a #0 -> beetbox#1 change when actually the index would be set to 0. Now, properly distinguish index 0 and None (i.e. not set)
wisp3rwind
added a commit
to wisp3rwind/beets
that referenced
this issue
Aug 19, 2019
fixes issue beetbox#3346: When the per_disc_numbering option was set, the UI would previously show a #0 -> beetbox#1 change when actually the index would be set to 0 (a valid index, such as for hidden tracks). Now, properly distinguish index 0 and None (i.e. not set)
wisp3rwind
added a commit
to wisp3rwind/beets
that referenced
this issue
Aug 19, 2019
fixes issue beetbox#3346: When the per_disc_numbering option was set, the UI would previously show a #0 -> beetbox#1 change when actually the index would be set to 0 (a valid index, such as for hidden tracks). Now, properly distinguish index 0 and None (i.e. not set)
Should be fixed on master now, if it isn't, please reopen this issue. Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On importing this album:
https://musicbrainz.org/release/bbf6ecfb-cb4f-401c-9d05-2b6c22d1366d
I get this:
Which suggests that that track will be tagged as track 1, but in fact it is correctly imported as track 0. I would expect the import to show no changes.
The text was updated successfully, but these errors were encountered: