Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer: "Keep both" should be "keep all" #3569

Open
RollingStar opened this issue Apr 25, 2020 · 2 comments
Open

Importer: "Keep both" should be "keep all" #3569

RollingStar opened this issue Apr 25, 2020 · 2 comments
Labels
feature features we would like to implement

Comments

@RollingStar
Copy link
Collaborator

RollingStar commented Apr 25, 2020

Problem

When importing duplicate albums, the importer will prompt to "keep both" if "ask" is set in the config.

(u'Skip new', u'Keep both', u'Remove old', u'Merge all')

This is true even when you have 2+ duplicate albums already in your library and are trying to add another duplicate. For simplicity and clarity, it should be "keep all".

If we make the change, a few docs and comments will have to change too. Nothing major.

https://github.com/beetbox/beets/search?q=%22keep+both%22&unscoped_q=%22keep+both%22

@sampsyo sampsyo added the feature features we would like to implement label Apr 25, 2020
@sampsyo
Copy link
Member

sampsyo commented Apr 25, 2020

Good call. Do you think it would be too crazy for it to dynamically switch between "keep both" (for 2) and "keep all" (for >=3)? Probably not necessary, just thought I'd wonder aloud to see if it seemed worthwhile. 😃

@RollingStar
Copy link
Collaborator Author

Good question. IMO, if more verbose comparison dialog is ever implemented (such as #2852), "keep all" will be more intuitive even with just 2 albums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

2 participants