-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in autobpm module (at least with Python 3.7) #5289
Comments
Hey! I can create a pull request with the suggested change if it's suitable. |
Ran into this yesterday before checking the forums. I changed one line as a quick fix. bpm = int(tempo.round()[0]) |
Fixes #5289 and #5185 Tried using the `autobpm` plugin and found a couple of issues: 1. #5185 `librosa` dependency was missing in `pyproject.toml` 2. Simply including the plugin in the configuration made `beet` take over 4 seconds to start up. 3. BPM detection failed due to another missing dependency, `resampy` 4. #5289 Librosa `beat_track` function returned unexpected type which made the plugin and the entire import process fail. Addressed each of the above, slightly refactored the plugin and added tests.
Encountered the same issue with autobpm and python 3.10 and beets 2.0, used the fix above. |
This fix is no good when a float is encountered, also the |
Problem
Trying to import an album with the new autobpm plugin, first I had to install
librosa
andresampy
to get it to run, those dependencies should probably be documented.Then it failed with:
Adding an
import numpy
and changing the indicated line tobpm = numpy.round(tempo)
fixed it here. Might just be a Python 3.7 problem, but the 2.0.0 release notes still claim Python 3.7 support.Setup
The text was updated successfully, but these errors were encountered: