Import log says "None" in album-grouping mode

[smcvb]

Found this issue while importing a large music set from which I only want the tagged data in my database, so not alter the files (move/rename) in any fashion. I didn't fancy taking every auto-tag issue into account, hence I imported the files in quite mode and logged the music files which it couldn't tag so I could do those by hand later. However, since the log only contained "Skipped none" and I did not move or alter any of my files, I had no way of telling which files weren't logged.

In short, when you are importing music in quite mode and want to log which files are skipped, the log only contains lines like "Skipped none".

[sampsyo]

Thanks for the report!

Oddly, I can't reproduce this. I've imported a few albums in quiet mode with the logger turned on that were then skipped, any my log contained:

import started Mon Jun 16 14:08:43 2014
skip /Users/asampson/[...]

Do you have a minimal configuration that makes the bug happen?

[smcvb]

Guessing that it only has something to do with the import function, here are the settings for import:

import:
    move: yes
    write: no
    resume: yes
    default_action: skip 
    non_rec_action: skip
    group_albums: yes
    log: skippedFiles.log
    incremental: yes
    detail: yes

[sampsyo]

Aha! Thanks for the additional detail.

The problem is the group_albums setting. The log typically contains the directory containing the skipped album, but in group_albums mode, there is no directory uniquely associated with each album—hence None.

We should fix this bug, but I'm not entirely sure what we ought to be logging. Maybe the full list of filenames? Certainly not the directory containing the music, since the whole point of group_albums is that you have many albums in jumbled together in the same directory.

[smcvb]

Aah cool, that makes a lot of sense actually.

Logging the complete list would be the most logical choice I'd say, since it will give a user the same info as when group_albums was not selected: which files couldn't be auto-tagged. Maybe it is a good idea to put a note in the manual at group_albums or log that logging will not work as expected when group_albums has been set?

For time being I will set the group_albums settings off since it is an easy issue to work around with my music library.

[sampsyo]

Yes, a note in the docs would not go amiss either. Edits would be appreciated here.

[smcvb]

An edit for the group_albums note on the Configuration page (http://beets.readthedocs.org/en/v1.3.6/reference/config.html) could be:

---

group_albums

By default, the beets importer groups tracks into albums based on the directories they reside in. This option instead uses files’ metadata to partition albums. Enable this option if you have directories that contain tracks from many albums mixed together.

The --group-albums or -g option to the import command is equivalent, and the G interactive option invokes the same workflow.

EDIT
Note: the log option set by -l will not log as expected when the group-albums options has also been set. Logging logs the albums which cannot be logged based on the album name. The group_albums setting however expects that there is no album name, hence the log functionality has no album name to log the failed auto-tag to.

If both -l and ---group-albums are set, the log will containg Skipped none messages instead of Skipped [insert_album_name].
END EDIT

Default: no.

---

Something similar should be in place for the documentation on the Command-Line Interface page (http://beets.readthedocs.org/en/v1.3.6/reference/cli.html).

[sampsyo]

Thanks! Incorporated.