Support for APEv2 cover tags #1042
Conversation
| @@ -868,7 +868,7 @@ class VorbisImageStorageStyle(ListStorageStyle): | |||
| base64-encoded. Values are `Image` objects. | |||
| """ | |||
| formats = ['OggOpus', 'OggTheora', 'OggSpeex', 'OggVorbis', | |||
| 'OggFlac', 'APEv2File', 'WavPack', 'Musepack', 'MonkeysAudio'] | |||
| 'OggFlac'] | |||
There was a problem hiding this comment.
Cool—I think the answer is "yes", but just to confirm: all three formats almost always use APE tags, right (WavPack, Musepack, and Monkey's Audio)? I've never run across any with Vorbis comments, but it would be great to have a second opinion.
There was a problem hiding this comment.
Yes, all these formats use ape tags as primary metadata format. The mutagen classes also inherit from APEv2File.
|
Awesome! Thank you for looking into this—and for the links to the background discussion. ✨ 😃 ❗ This implementation looks solid, and I'm not to worried about losing compatibility with Vorbis-style images in APE tags. Before we hit merge, can I have your help fitting in with beets style—namely, just wrapping to 79-character lines should do well. |
|
Fantastic! Thanks so much for fiddling with the style. I'll merge this now. ✨ |
|
Cool. Thanks for merging! |
I have added support for APEv2 cover tags. There seems to be no official specifications for these tags but they are supported by several tagging tools. The origin of the tags can be found here: http://www.hydrogenaud.io/forums/index.php?showtopic=40603, sample files here: http://www.hydrogenaud.io/forums/index.php?showtopic=40860
I have created a separate APEv2ImageStorageStyle class for the APEv2 related formats. However, this results in APEv2 tags containing vorbis comment like covers no longer being recognized. I am not sure if this is a valid use case. If you want, I can change the implementation to support both formats.