Added backed audiotools to replaygain module and updated documentation #1070
Conversation
|
This looks quite solid! Thanks! Looks like there are a few lines that are longer than 80 characters (c.f.). I know it's a tiny thing, but would you mind wrapping those? If anyone has the dependencies in working order, a quick sanity-check on another system would be awesome. |
| @@ -70,7 +76,7 @@ configuration file. The available options are: | |||
|
|
|||
| - ``auto``: Enable ReplayGain analysis during import. | |||
| Default: ``yes``. | |||
| - ``backend``: The analysis backend; either ``gstreamer`` or ``command``. | |||
| - ``backend``: The analysis backend; either ``gstreamer``, ``command`` or ``audtiotools`. | |||
There was a problem hiding this comment.
audtiotools should be audiotools
There was a problem hiding this comment.
Should be fixed now, let me know if it works for you.
Conflicts: docs/plugins/replaygain.rst
Added backed audiotools to replaygain module and updated documentation
This looks mostly helpful for debugging but redundant with the ordinary logging.
|
Thanks! I can't test this thoroughly at the moment, but it looks like it's in order. I made a few small changes in logging & style, but otherwise merged as-is. |
|
Good, I'll take a moment to comment the code a bit later, let me know if it works. |
|
I pulled your commits, maybe you've got the wrong name in the changelog? |
|
Oh no; how embarrassing! Sorry. 😳 I must have been looking at the wrong profile page when I typed that. |
|
No problem at all. |
Added a backend that uses http://audiotools.sourceforge.net like discussed and updated the documentation a bit.
I'll add comments later on, but I'd like for people to test the code if possible.
Francesco