convert: Fix quoting on Windows #1157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 19, 2014 23:14
mluds
changed the title
Closed
sampsyo
added a commit
that referenced
this pull request
Dec 21, 2014
Log as one statement. No need to hold the filesystem lock. New variable name.
sampsyo
added a commit
that referenced
this pull request
Dec 21, 2014
Now that we do the proper thing, we do not need shell parsing.
sampsyo
added a commit
that referenced
this pull request
Dec 21, 2014
sampsyo
added a commit
that referenced
this pull request
Dec 21, 2014
Don't require $source and $dest to be bare tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix uses
shlex.splitto create an argument list and passes it instead of a string.command_outputwas modified to include error output in its exception.encodemakes use of this (so we can seeffmpegerrors with the-voption). See #1026.