-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetchart: add fetching artwork from Wikipedia #1194
Conversation
Interesting approach ! Hadn't heard of dbpedia before. |
Looks good, I just fixed buckets tests that made the Travis build failed. |
Wow, very cool! This is a nifty use of dbpedia. Thanks, @Kraymer, and I agree: this will be totally ready to merge once flake8 and docs are ready. |
@Kraymer, given a recent refactorisation your work cannot be cleanly merged any more. Could you update it? You simply have to create a |
@brunal je crois que tu voulais t'adresser à tomjaspers plutôt non ? ;) |
Right... @tomjaspers could you update that PR to make it mergeable? |
@brunal I was waiting until the refactorisation was merged. I'll do an update tomorrow. |
…-based structure of the plugin
@sampsyo Is this good to be merged, or need I do something else ? |
Looks good; thank you, @tomjaspers! I blame the week-long delay here on GitHub, who does not notify me when people add new commits to a pull request. Thanks for commenting, which brought my attention back. Merging now. |
Fetchart: add fetching artwork from Wikipedia
Query DBpedia using SPARQL to obtain the filename of the album's cover, as it is used on the relevant Wikipedia article. The direct image url is then obtained using Wikipedia's API.