Don't crash when no argument is given #1207
Conversation
|
Dang, do I feel dumb now. |
Don't crash when no argument is given
| @@ -924,7 +924,8 @@ def _raw_main(args, lib=None): | |||
| # Special case for the `config --edit` command: bypass _setup so | |||
| # that an invalid configuration does not prevent the editor from | |||
| # starting. | |||
| if subargs[0] == 'config' and ('-e' in subargs or '--edit' in subargs): | |||
| if subargs and subargs[0] == 'config' \ | |||
| and ('-e' in subargs or '--edit' in subargs): | |||
There was a problem hiding this comment.
Isn't the indentation off by one? Eh. I guess flake8 didn't complain so it's probably all good. Just seemed odd to me.
There was a problem hiding this comment.
Oh, I guess it just follows the identation of "subargs". Right. I'm too tired to look at code right now. :)
There was a problem hiding this comment.
Good catch. I guess it's visually aligned with the start of the expression on the previous line. In any case, feel free to fiddle with it using your newfound commit powers. 😃
There was a problem hiding this comment.
Yes that's right! How would you prefer it to be? That's what pep8 prefers
There was a problem hiding this comment.
This is good actually! It's just a bit funny because it's 3 spaces, which is almost 4 spaces. Let's leave it.
Check that there is a sub-argument before getting the first one. Fixes issue #1205