Display clear error message when MusicBrainz is unreachable #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainz not reachable" Catch musicbrainzngs.WebServiceError before the general musicbrainzngs.MusicBrainzError Fix #1190
|
Great; thanks for getting to the bottom of this. Can I suggest a slightly different fix that requires less duplicated code? Inside That is, we can centralize this check and string literal in one place if we move it to the exception constructor. |
|
@sampsyo Good suggestion; I knew there had to be a better solution. |
sampsyo
added a commit
that referenced
this pull request
Jan 28, 2015
Display clear error message when MusicBrainz is unreachable
sampsyo
added a commit
that referenced
this pull request
Jan 28, 2015
|
Merged! Thanks for taking care of this. ✨ That's two contributions in one week for you! A double thank-you is in order. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.:
Error: MusicBrainz not reachable in get release by ID with query etc etc ...Catch musicbrainzngs.WebServiceError before the general musicbrainzngs.MusicBrainzError
Fix #1190