-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin to sync metadata from other applications. #1386
Conversation
This looks very cool! I've been meaning to make something to sync iTunes metadata, but a general player syncing plugin is even better, and make that task easier. My two comments:
Name-wise: more of a fan of the full PlayerSync over the psync |
That's really cool!
|
Cool indeed! Both comments above cover my thoughts too. I wonder if a general mechanism for adding the player name as a prefix would be useful. If I were using this plugin, for example, I might not want to use the prefix at all—since I'd only sync with one player, just plain old "playcount" might be enough (along the lines of |
bf1c60e
to
5083471
Compare
I adapted the plugin loading to be a bit more dynamic now. Alas, the item_types are still in |
If this is already useful for Amarok, should we merge this now and keep evolving it in tree? I too would lean toward |
No objections from my side :) |
Hey, I forgot to ask! Could you please write the documentation for the initial version? If this doesn't seem user-facing yet, we could of course keep it in a branch for a while until it seems documentation-worthy. |
07527ec
to
4c65981
Compare
I think it's perfectly fine to be used by users already. I don't think any of the architectural changes left for discussion would have any notable impact on what's presented to the user at this point. |
@@ -104,6 +105,7 @@ Metadata | |||
* :doc:`lastimport`: Collect play counts from Last.fm. | |||
* :doc:`lyrics`: Automatically fetch song lyrics. | |||
* :doc:`mbsync`: Fetch updated metadata from MusicBrainz | |||
* :doc:`metasync`: Fetch metadata from local or remore sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: 'remore'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed
Looking great. Thank you for adding documentation. I'm going to merge this now and describe it as "experimental" in the changelog—just because I imagine the way it works might evolve as we add more player backends. |
Apropos of nothing, maybe this would be a good home for what currently lives in the |
Plugin to sync metadata from other applications.
This is the initial version of a plugin to synchronize metadata with other applications (at some point maybe even bi-directional). It allows syncing from multiple sources, specified either in the config file or on the command line.
One example source is already implemented in the form of syncing data from amarok over its dbus interface.
I'm not picky on the name, if someone has better suggestions I'm all ears. I picked 'psync' (player sync) to make it a bit better distinguishable from mbsync than maybe a plain 'sync' would be.