PlexUpdate plugin updated for Plex Home #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlexUpdate plugin updated to allow Plex Tokens to be provided with the server details so that beets can update a Plex library that requires authentication.
| """Appends the Plex Home token to the api call if required. | ||
| """ | ||
| if token: | ||
| url += '?X-Plex-Token={0}'.format(token) |
There was a problem hiding this comment.
For safety, it's probably best to use:
url += '?' + urllib.encode({'X-Plex-Token': token'})
|
Looks great, modulo the one small suggestion above! Would you mind adding to the documentation for the plugin (and a changelog entry)? |
Updated the append function to be a bit safer when adding the token parameter. Updated docs and changelog
|
No problem - included your suggestion and updated the docs :) |
|
Awesome. Thank you for adding this! ✨ |
sampsyo
added a commit
that referenced
this pull request
Jun 4, 2015
PlexUpdate plugin updated for Plex Home
sampsyo
added a commit
that referenced
this pull request
Jun 4, 2015
LordSputnik
pushed a commit
to LordSputnik/beets
that referenced
this pull request
Jul 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the PlexUpdate plugin to allow Plex Tokens to be provided with the
server details so that beets can update a Plex library that requires
authentication.