-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in importer. #1535
Merge in importer. #1535
Conversation
When duplicate records are found during import, the user has the option to merge the two sets together. Presently, only works when tracks don't conlict.
@sampsyo a few questions:
|
Hi! Thank you for writing this! It looks amazing, and it fulfills something that many people have asked for. And I'm very very sorry that I didn't get around to this earlier—thanks for your patience while I caught up on the backlog. I'll review the code now. To answer your questions:
I'm not 100% sure what's going on here—are you referring to the new
Is the idea to let you break apart an album and then merge part of it into a new album? That sounds like a rather complex thing to orchestrate. Would you mind terribly much if we left that extension until after we finish this more basic version?
Probably—depending on where the user input comes in.
That's not your fault, and now fixed. Nothing to worry about!
So far so good; it seems to do its job admirably, and it's great that it's free for open source. It's disabled for us, unfortunately, because we haven't gotten all the tests passing on Windows quite yet (#670). |
@@ -810,6 +810,10 @@ def resolve_duplicate(self, task, found_duplicates): | |||
elif sel == 'k': | |||
# Keep both. Do nothing; leave the choice intact. | |||
pass | |||
elif sel == 'm': | |||
# Merge the two together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nitpick: for comments like this, please use a period at the ends of sentences.
Mad props to udibox1209, making this happen in #2725. |
When duplicate records are found during import, the user has the option to merge the two sets together. Presently, only works when tracks don't conflict.
This is not the final commit, I'm planning on resolving track conflicts before this is ready for merging. Before I head down that road though, I'd really like my work double-checked (@sampsyo). This project is impressively large, I did my best to understand this portion, but I'm not sure if I'm abusing the database or pipeline or something.
Cheers!
P.S. Related to issue #112