Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the clearart method in order to send write events to the plugins. #1565

Merged
merged 4 commits into from
Aug 24, 2015
Merged

Rewrite the clearart method in order to send write events to the plugins. #1565

merged 4 commits into from
Aug 24, 2015

Commits on Aug 22, 2015

  1. clearart-notify: Send write events when clearing art 

    For example, this led beets-check to not recompute hashes when
doing beet clearart [query]. Further operations on the file(s)
would then trigger beets-check to issue integrity warnings.
    nath@home committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    b6290e2 View commit details
    Browse the repository at this point in the history

  2. clearart-notify: Use item.try_write() to clear art 

    This method already groups reading the config, managing file I/O
and exceptions, as well as sending events to the plugins, so it's
really easier and cleaner to do it that way. Note that passing
'images':None as tags to update correctly triggers beets to delete
the images tag altogether.
    nath@home committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    b53798a View commit details
    Browse the repository at this point in the history

  3. clearart-notify: Use default arguments when clearing art

    nath@home committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    8773d95 View commit details
    Browse the repository at this point in the history

  4. clearart-notify: Added changelog entry

    nath@home committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    8bf60ee View commit details
    Browse the repository at this point in the history