New tests for human readable values #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: test/test_ui_commands.py
moved the tests of ui/__init__ to a new test file
|
Great! But yes indeed—it looks like the exponents in the original code are wrong. 😢 Would you mind fixing them too? |
|
I will be happy to fix it, but which style do we want to use? |
|
Good question. Let's say XiB (i.e., powers of two) since that's closest to what we're doing (or thought we were doing) already. |
using unit e.g. 5.4 KiB instead of 5.4 KB now
|
So i think i fixed it now. |
|
Awesome. ✨ I'll hit the merge button now, but would you mind also adding a note to the changelog about the fix? |
sampsyo
added a commit
that referenced
this pull request
Sep 30, 2015
New tests for human readable values
pkess
added a commit
to pkess/beets
that referenced
this pull request
Sep 30, 2015
pkess
added a commit
to pkess/beets
that referenced
this pull request
Sep 30, 2015
pkess
added a commit
to pkess/beets
that referenced
this pull request
Sep 30, 2015
|
Done. Hope you enjoy it |
|
Looks perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here i added some tests for the output of human readable values.
Especially the test of human_bytes is written as it would success now. But is the implementation really correct?
As you see at https://en.wikipedia.org/wiki/Petabyte a Petabyte is 10^15 bytes and not 2^50 bytes as implemented.