Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #314: Delete old album art during re-import #1681

Merged
merged 9 commits into from
Nov 4, 2015
Merged

Fix #314: Delete old album art during re-import #1681

merged 9 commits into from
Nov 4, 2015

Commits on Nov 2, 2015

  1. Importer: Delete orphaned album art on re-imports 

    First step towards fixing #314.
    @reiv @sampsyo
    reiv authored and sampsyo committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    629a80a View commit details
    Browse the repository at this point in the history

  2. PEP8 amendments

    @reiv @sampsyo
    reiv authored and sampsyo committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    413fe6b View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2015

  1. Revert all changes on this branch thus far 

    Revert "PEP8 amendments"

This reverts commit 413fe6b.

Revert "Importer: Delete orphaned album art on..."

This reverts commit 629a80a.
    @reiv
    reiv committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    33ea9f1 View commit details
    Browse the repository at this point in the history

  2. Add test for #314 

    Ensure that album art is preserved when an album is re-imported.
    @reiv
    reiv committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    21f926f View commit details
    Browse the repository at this point in the history

  3. Preserve album art on re-import (fixes #314) 

    Copy the replaced album's artpath attribute to the new album. This
causes the image file to be moved along with the music files.
    @reiv
    reiv committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    32934bd View commit details
    Browse the repository at this point in the history

  4. Update re-import test to leave no orphaned art 

    Make sure that when an album is re-imported and its files are
moved, the artwork isn't left behind in the old folder.
    @reiv
    reiv committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    314dd0e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2015

  1. fetchart: in auto, ignore albums with art 

    When re-importing an album, we don't want fetchart to interfere
with any existing album art.
    @reiv
    reiv committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    0ebc4c7 View commit details
    Browse the repository at this point in the history

  2. Changelog for #1681

    @reiv
    reiv committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    e32dda7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 314-reimport-art

    @reiv
    reiv committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    81a72f7 View commit details
    Browse the repository at this point in the history