Importer UI overhaul #1685

sampsyo · 2015-11-02T18:42:55Z

This is mxmerz/ui, pulled into the main tree. See screenshots and such at #1593.

- Add ANSI styles, colors and background-colors - Modify colorize functions to adopt new colors - Modify default configuration to adopt new color scheme: - Define colors by arrays with their ANSI codes as strings - Deprecated DARK_COLORS and LIGHT_COLORS

for easy indentation and alignment

- when linebreaking, ANSI codes should end at word borders - this removes change markers for whitespace!

- colors arbitrary strings according to a distance - refactor dest_string

- more concise format

- reintroduce support for legacy colors - replace DARK_COLORS and LIGHT_COLORS with LEGACY_COLORS and map color names onto their counterpart in the new “advanced” color definition system - also continue to support new “advanced” colors - cleaner code (at least I think so)

sampsyo · 2016-01-09T20:00:13Z

Hi! This was looking pretty close to ready for beta-level publicity. Shall we regroup and finish it off? Maybe we should start by making a to-do list of outstanding changes.

mxmerz · 2016-01-09T20:46:48Z

I’m very sorry for the long silence from my side – I had a busy November and December and am currently in my exam period… I hope to be able to help with this again in 1-2 weeks. From what I immediately remember, the dirty code I hastily hacked together worked okayish, but was severely lacking in quality, simplicity, documentation, and tests. And I am sure that the new UI is not showing changes for some tags, eg. track length, or when the chroma id didn’t match.
Sorry again for this half-assed amateur work, if no-one else dares to touch it I promise to get to it as soon as my exams are over and I have a bit more free time.

sampsyo · 2016-01-09T20:49:46Z

Fantastic! And no problem whatsoever—open-source hacking necessarily has to take second place behind exams. Thanks for keeping it in mind, and no rush at all.

I'll let you take the lead, but I'm happy to pitch in with code quality and such.

ekjaker · 2016-01-13T15:53:38Z

And maybe I can help out with some testing. I have been using these modifications for a large tagging job, and it worked nicely. As it is now, it's already a huge improvement.

sampsyo · 2016-01-13T16:49:21Z

Awesome! Yes, testing is great. Please do post if you run into any problems.

Adjusting the unit tests for the new UI would be helpful too.

mxmerz · 2016-01-27T14:20:33Z

I have a few new commits over at mxmerz/ui.

The “old” color definitions with a single string should work again.

I tried to refactor the show_change function in ui/commands.py – I split the function into show_match_header, show_match_details, and show_match_tracks and tried to split these again into smaller functions. My python skills are limited; I am not sure whether this is the best way to approach this and would appreciate feedback before I continue.

In ui/__init__.py, I added a function uncolorize which strips ANSI codes from a string and color_len, which measures the length of a colored string (len(uncolorize(string))). In uncolorize, I used a StackOverflow-inspired regex, do you know whether that is compatible with beet’s license and correctly attributed? I actually hope to get rid of both functions again, it does not seem to be a very elegant way…

sampsyo · 2016-01-27T19:56:23Z

Great! This looks like solid progress.

I sent you an invitation to join the @beetbox organization, which should let you merge your changes into the ui branch on this repository. Would you mind doing that?

And while uncolorize looks like a useful stopgap, I agree with you about eventually finding a solution that doesn't require it. Ideally, we'd be able to do things like getting the length of the string once, before adding colors, and avoid the cost of colorizing and then re-de-colorizing to recover the length.

- move construction of lhs and rhs dicts to make_line - move make_track_titles, make_track_numbers, and make_track_lengths to make_line

- add 'changed' key to info dict to indicate whether rhs should be displayed at all

GuilhermeHideki · 2016-04-22T17:14:55Z

For the colorize problem, you could subclass or composite str or unicode and create a field with the length, and in a colorize method, you would "overwrite" the uncolorized string with the colorized.

Create color mapper functions outside of the forloop.

Instead of sometimes moving the last word in the last line, just always add an empty line as the new last line.

The class should make it easier to handle state when showing a change. - Move show_match_header and show_match_details to the new class.

jtpavlock · 2020-07-10T00:11:22Z

Anything else that needs to be done here?

sampsyo · 2020-07-11T17:25:28Z

I think what this needs is some good old fashioned TLC—taking some time to review everything in detail and think carefully about the changes. I think the outcome (i.e., the resulting UI) already looks awesome.

stale · 2020-11-18T00:50:45Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mxmerz added 21 commits November 1, 2015 17:25

UI: Add more ANSI colors

a9ed100

- Add ANSI styles, colors and background-colors - Modify colorize functions to adopt new colors - Modify default configuration to adopt new color scheme: - Define colors by arrays with their ANSI codes as strings - Deprecated DARK_COLORS and LIGHT_COLORS

UI: Add ui.indent() method

1cf39db

for easy indentation and alignment

UI: Colorize prompt

6bb6898

UI: fixup color names

f43a5c8

UI: place ANSI codes at word borders in _colordiff

6b1f215

- when linebreaking, ANSI codes should end at word borders - this removes change markers for whitespace!

UI: Separate disambiguation elements with pipe

6a556c9

UI: Add dist_colorize function

daf635a

- colors arbitrary strings according to a distance - refactor dest_string

UI: Prefix penalties string with NOT EQUAL TO sign

238efe5

UI: Change show_change header style

c541ec8

- more concise format

UI: Change candidate selection view

d708022

UI: Apply ANSI styles to import task path string

e9caa7a

UI: Implement two layouts for track changes

42f55b1

UI: Add config options to set match indentation

ced7dc4

UI: Always show disk info in tracklist

3356afb

UI: change default configs for import layout

6a006ed

UI: add text, text_faint colors

bd34709

UI: fixup typo in comment, remove debug statement

3ce0638

UI: refactor code for change of track # or length

c593327

UI: fixup track # alignment in column view

9a4a15f

UI: refactor calculation of available columns

69e2f3a

mxmerz added 4 commits January 23, 2016 13:04

refactor printing the match header

0bb3979

change string to unicode; add whitespace

7c8ac73

split show_change method into parts

605b731

fixup unicode errors

c88f560

fixup comment

55493a1

mxmerz added 7 commits February 18, 2016 19:46

move two methods into show_match_tracks()

1584c07

remove unused show_album(artist, album)

9a50224

minor whitespace change

0b1ba73

restructure format_tracks_as_columns

1b424db

new make_line method

8f578e4

- move construction of lhs and rhs dicts to make_line - move make_track_titles, make_track_numbers, and make_track_lengths to make_line

move format_index to show_match_tracks

36f53ef

add indentation to info dict

87c38c1

- add 'changed' key to info dict to indicate whether rhs should be displayed at all

wisp3rwind mentioned this pull request Mar 25, 2016

Fetchart preview/General thoughts on user interaction by plugins #1917

Closed

GuilhermeHideki assigned GuilhermeHideki and unassigned GuilhermeHideki Apr 22, 2016

mxmerz mentioned this pull request Sep 11, 2017

import formatting hard to parse mentally #1593

Open

mxmerz added 9 commits April 1, 2018 12:08

Remove unused kwargs from colordiff and _colordiff

bd0b564

Refactor mapper functions in _colordiff

de7717e

Create color mapper functions outside of the forloop.

Improve comments in ui/__init__.py

ac03469

Simplify handling of overlong last lines in split_into_lines

26c2e1f

Instead of sometimes moving the last word in the last line, just always add an empty line as the new last line.

Whitespace

1df0689

Modify disambig_string to return colorized string

df2d7ad

Improve comments

9232e15

Use unicode string when showing empty artist

275931e

Add ChangeRepresentation class

6de8e54

The class should make it easier to handle state when showing a change. - Move show_match_header and show_match_details to the new class.

davidswarbrick mentioned this pull request Aug 6, 2020

Importer UI overhaul rebase/update #3721

Merged

8 tasks

stale bot added the stale label Nov 18, 2020

stale bot closed this Nov 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Importer UI overhaul #1685

Importer UI overhaul #1685

sampsyo commented Nov 2, 2015

sampsyo commented Jan 9, 2016

mxmerz commented Jan 9, 2016

sampsyo commented Jan 9, 2016

ekjaker commented Jan 13, 2016

sampsyo commented Jan 13, 2016

mxmerz commented Jan 27, 2016

sampsyo commented Jan 27, 2016

GuilhermeHideki commented Apr 22, 2016

jtpavlock commented Jul 10, 2020

sampsyo commented Jul 11, 2020

stale bot commented Nov 18, 2020

Importer UI overhaul #1685

Importer UI overhaul #1685

Conversation

sampsyo commented Nov 2, 2015

sampsyo commented Jan 9, 2016

mxmerz commented Jan 9, 2016

sampsyo commented Jan 9, 2016

ekjaker commented Jan 13, 2016

sampsyo commented Jan 13, 2016

mxmerz commented Jan 27, 2016

sampsyo commented Jan 27, 2016

GuilhermeHideki commented Apr 22, 2016

jtpavlock commented Jul 10, 2020

sampsyo commented Jul 11, 2020

stale bot commented Nov 18, 2020