Fix for crash when sorting by nonexistent field (#1734) #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix crash when sorting by nonexistent field. * Add tests for queries with nonexistient fields for sorting.
| for r1, r2 in zip(all_results, results): | ||
| self.assertEqual(r1.id, r2.id) | ||
|
|
||
| def test_field_present_in_some_items(self): |
There was a problem hiding this comment.
A small remark for this test case: when the field is only present on some items and sorting by that field on ascending order, the items that do not have that field are displayed at the top of the list. While it does make sense, I'm wondering if it might be a bit confusing for end users: perhaps a small clarification or note on the Queries - Sort order docs might be in order?
There was a problem hiding this comment.
Great idea! A note in the docs would be awesome.
|
Fantastic! Thank you for being so thorough with the tests. ✨ This is clearly something we would have caught earlier with a more complete test suite for sorting. |
sampsyo
added a commit
that referenced
this pull request
Nov 25, 2015
Fix for crash when sorting by nonexistent field (#1734)
sampsyo
added a commit
that referenced
this pull request
Nov 26, 2015
Documentation update: followup to #1736, fix typo on inline.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1734 as suggested on the discussion (by simply replacing the line on
dbcore.query.sort()). Also added a handful of test for making sure it works as expected.