Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetchart plugin: new google custom search engine backend #1778

Merged
merged 13 commits into from
Dec 30, 2015

Conversation

lcharlick
Copy link
Contributor

This restores the fetchart plugin’s google backend (see #1760) using the google custom search API.
Configuration options are identical to the lyrics plugin.

@sampsyo
Copy link
Member

sampsyo commented Dec 29, 2015

This is awesome! Thanks for bringing this back—and double thanks for adding the readable, mock-based tests. ✨

Can I ask for one small change? Although using the configuration keys from the lyrics plugin was a good idea, those names don't fit well with the rest of beets' configuration. (I regret settling on those names in the first place.) Can you change them for this plugin to something more consistent and lower-case? For example, google_key and google_engine would be fine, as would apikey and engine underneath a google: subsection.

@lcharlick
Copy link
Contributor Author

OK, I renamed the keys to google_key and google_engine.
Glad to hear the tests are alright - I’d never used the responses library before.

@sampsyo
Copy link
Member

sampsyo commented Dec 30, 2015

Awesome; thank you again. I'll merge this now.

sampsyo added a commit that referenced this pull request Dec 30, 2015
Fetchart plugin: new google custom search engine backend
@sampsyo sampsyo merged commit 1033e1d into beetbox:master Dec 30, 2015
sampsyo added a commit that referenced this pull request Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants