AcousticBrainz Plugin

[opatel99]

No description provided.

[sampsyo]

The usual way to format long lines like this is to wrap inside the parentheses. For example:

cmd = ui.Subcommand('acoustic',
                    help='...')

or:

cmd = ui.Subcommand(
    'acoustic',
    help='...',
)

rather than using a constant.

[sampsyo]

Can we use the plain names from AB? For example, just danceable instead of abrainz_dance. The prefix probably doesn't matter, but it would be nice to match the terminology from AB.

[sampsyo]

This is awesome. ✨ Nice work—this is very close to ready to merge. Two outstanding issues:

• The name of the plugin. What do you think about something slightly more specific—like abrainz or even the full acousticbrainz? It seems like acoustic might sound sort of ambiguous to someone not familiar with the various XBrainzes.
• Could you please draft an initial documentation page for the plugin? It can be very simple, since the plugin is very simple at the moment. You can copy from another similarly simple plugin, like info. The appropriate place is docs/plugins/NAME.rst.

[Freso]

I would personally prefer AcousticBrainz as a beets user and as a MetaBrainz spokesperson. We may do other A*Brainz projects in the future, and "acousticbrainz" also directly reflects that it's to do with AcousticBrainz, instead of having to wonder what service "ABrainz" is.

[Freso]

What timezone are you in again? 😆 Unless you're in Japan or Eastern Australasia, I would assume that judging by the earliest commit here, it should at least be 2015-2016. :)

[sampsyo]

Yeah, I can get behind acousticbrainz as a plugin name too—I don't mind making a name change.