-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add musicbrainz id option to importer #1808
Commits on Jan 11, 2016
-
Add musicbrainz id option to importer
* Add '-m', '--musicbrainzid' option to the import command, allowing the user to specify a single MusicBrainz ID to be used for the candidate lookup instead of trying to find suitable candidates. * Modify lookup_candidates() of ImportTask and SingletonImportTask to use the musicbrainz id if present.
Configuration menu - View commit details
-
Copy full SHA for 1c95b7c - Browse repository at this point
Copy the full SHA 1c95b7cView commit details
Commits on Jan 19, 2016
-
Allow multiple MB ids to be passed to the importer
* Modify the "--musicbrainzid" argument to the importer so multiple IDs can be specified by the user instead of a single one. * Revise autotag.match.tag_album and autotag.match.tag_item signature to expect a list of IDs (search_ids) instead of a single one (search_id), and add logic for handling and returning multiple matches for those IDs. * Update calls to those functions in other parts of the code.
Configuration menu - View commit details
-
Copy full SHA for 48c92fb - Browse repository at this point
Copy the full SHA 48c92fbView commit details -
Add tests for importer musicbrainz id argument
* Add tests for the "--musicbrainzid" argument (one/several ids for matching an album/singleton; direct test on task.lookup_candidates() for album/singleton).
Configuration menu - View commit details
-
Copy full SHA for 865be11 - Browse repository at this point
Copy the full SHA 865be11View commit details -
Configuration menu - View commit details
-
Copy full SHA for c12e974 - Browse repository at this point
Copy the full SHA c12e974View commit details
Commits on Jan 20, 2016
-
Avoid querying MB during ImportMusicBrainzIdTest
* Replace the entities used on ImportMusicBrainzIdTest mocking the calls to musicbrainzngs.get_release_by_id and musicbrainzngs.get_recording_by_id instead of querying MusicBrainz. * Other cleanup and docstring fixes.
Configuration menu - View commit details
-
Copy full SHA for 4e5ddac - Browse repository at this point
Copy the full SHA 4e5ddacView commit details -
Fix singleton candidate ordering when using MB id
* Fix an issue that caused the candidates for a singleton not to be returned ordered by distance from autotag.match.tag_item(), when searching multiple MusicBrainz ids (ie. several "--musicbrainzid" arguments). The candidates are now explicitely reordered before being returned and before the recommendation is computed. * Fix test_importer.mocked_get_recording_by_id so that the artist is nested properly (and as a result, taken into account into the distance calculations).
Configuration menu - View commit details
-
Copy full SHA for 39cf465 - Browse repository at this point
Copy the full SHA 39cf465View commit details
Commits on Jan 21, 2016
-
Cleanup and documentation for MB_id importer arg
* Style cleanup and fixes for the "--musicbrainzid" import argument. * Allow the input of several IDs (separated by spaces) on the "enter Id" importer prompt. * Add basic documentation.
Configuration menu - View commit details
-
Copy full SHA for b526227 - Browse repository at this point
Copy the full SHA b526227View commit details -
Store user-supplied MB ids on the Tasks
* Store the user-supplied MusicBrainz IDs (via the "--musicbrainzid" importer argument) on ImporTask.task.musicbrainz_ids during the lookup_candidates() pipeline stage. * Update test cases to reflect the changes.
Configuration menu - View commit details
-
Copy full SHA for 4eedd2b - Browse repository at this point
Copy the full SHA 4eedd2bView commit details
Commits on Jan 22, 2016
-
Style and doc fixes for MB_id importer argument
* Rename the importer argument and related variables to make it more generic, as the feature should be independent of the backend used and not restricted to MusicBrainz. * Update documentation and docstrings accordingly. * Add changelog entry.
Configuration menu - View commit details
-
Copy full SHA for 79d84c0 - Browse repository at this point
Copy the full SHA 79d84c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f51302 - Browse repository at this point
Copy the full SHA 4f51302View commit details