Rewrite handling of images extensions and mimetype #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathdwek
force-pushed
the
fix-2254-1545
branch
from
767519d
to
4f081e6
Compare
|
Awesome! Thank you for the fast fix. This looks basically ready to merge, and I don't mind having the new utility class. A couple of small suggestions:
|
nathdwek
pushed a commit
that referenced
this pull request
Nov 8, 2016
|
Looks great! I say merge whenever you like. |
added 5 commits
November 8, 2016 18:48
Apply #1545 to a public function used everywhere
nathdwek
force-pushed
the
fix-2254-1545
branch
from
91eccc8
to
f236816
Compare
|
I added a test and rebased. Will merge as soon as this passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IdentityUnlessDictpart is probably a bit overkill for this fix, but I like to play around with collections these days. Tell me what you think about it.When we'll be able to merge #2251 (Hopefully),
DefaultListwould also end up inbeets.util.collections.Many thanks to @tweitzel for noticing this inconsistency.