Convert: Don't prompt for confirmation if query result is empty #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get cli options and configuration in a more readable, uniform way
sampsyo
reviewed
Nov 13, 2016
| ui.print_(format(i, u'')) | ||
|
|
||
| if not items: | ||
| self._log.info(u'No item to convert.') |
There was a problem hiding this comment.
I might suggest the wording "Nothing to convert." because saying "items" could be confusing when the user asked to convert albums.
nathdwek
pushed a commit
that referenced
this pull request
Nov 13, 2016
|
Should merge if tests pass. Ok with you @sampsyo ? |
|
Yes! Go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe one test coming tomorrow.
This should fix #2260